New warning in the packaging linux jobs about rcutils

[clalancette]

I'm not 100% sure yet, but I think the problem is this line:

rcutils/src/error_handling_helpers.h

Line 159 in befc608

size_t written = __rcutils_copy_string(offset, bytes_left, error_state->message);

.

The arguments to rcutils_copy_string are the destination pointer, the destination size, and the source pointer. In this case, the destination size is bytes_left, which is set to sizeof(error_string->str) in the previous line. However, there is no guarantee that the source has that many bytes to give. Now, I agree with you that this kind of defeats the purpose of the strnlen, so this is probably a false positive. Nevertheless, we can probably be defensive there and use the smaller of sizeof(error_string->str) and sizeof(error_state->message) as the bytes_left. I think that will get rid of the warning.

Do you want to try that out, or would you like me to poke at it more (I'm happy to do either)?

[Blast545]

I can try it out! I'll open a draft PR and check.

[Blast545]

Closed with #353

Reference newer case without the warning:
https://ci.ros2.org/view/packaging/job/packaging_linux/2572/