Comments (4)
Yes, the ros2
branch of this repo doesn't have any dependency on boost anymore. I was hoping to provide an std version of the various APIs by melodic but didnt get around doing it yet.
As modifying the signature of createInstance
will require any downstream package to adapt their code, I was thinking of creating a createSharedInstance
equivalent and deprecating the existing one.
Would that work for your use case ? (this will likely need pluginlib to do the same to be really useful, there's work in that direction here as well, but same thing not sure It'll be released in time for melodic)
from class_loader.
from class_loader.
the header file deprecation has been merged into Kinetic already,
The new headers are available on all active ROS distros (including indigo) so there should be no requirement for maintainers to branch out. And the headers should not be deprecated for Kinetic (or any distro except melodic) otherwise I messed up something along the way o_O.
I'd opt for getting the whole package done for Melodic :)
Agreed, that's the desired outcome, and I'll try to make it happen, in any spare cycle I can find.
Can you confirm that the API suggested above satisfies your use case?
from class_loader.
The header deprecation is all ok but I suppose many decided not to live with those warnings :)
Thanks, it would be great to have this for Melodic!
Most XyzSharedPtr
already use std::shared_ptr
, now packages either have a consistent pointer typedef set and they explicitly declare pluginlib
-returned instances to use boost::shared_ptr
or they have a mix of the two in the pointer typedefs.
The suggested API would provide a solution that can work for the long run.
from class_loader.
Related Issues (20)
- [ros2] Cannot find Poco on Windows HOT 1
- Memory leak: meta objects not destroyed HOT 3
- Progress toward Quality Level 1 HOT 3
- Link error with Poco when using libc++ HOT 1
- ClassLoaderTest.threadSafety test is noisy
- SEVERE WARNING!!! in tests
- Project 'class_loader' specifies '/include' as an include dir HOT 2
- Towards Quality Level 1 - Activate DCO
- Library/Dependency Detetction; Bug?
- mac ros build class_loader issue HOT 2
- ROS 2 Travis / AppVeyor CI broken
- Method createSharedInstance missing in ROS2 branches HOT 2
- Question: How to load library when dependencies are not in the LD_LIBRARY_PATH? HOT 2
- Can we have a 0.4.2 tag? HOT 4
- Is load_ref_count_ no need to count number?
- Notes on `RTLD_GLOBAL` in the code ? HOT 2
- Unnecessary conditional judgment in isLibraryLoaded ? HOT 1
- undefined reference to `class_loader HOT 4
- Remove raw pointer interface HOT 2
- ROS independent builds with rolling release?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from class_loader.