Coder Social home page Coder Social logo

Comments (6)

JafarAbdi avatar JafarAbdi commented on May 17, 2024

@bmagyar Is there any style that you would prefer (for example MoveIt clang-format .? I could create a PR to fix this issue

from ros2_control.

bmagyar avatar bmagyar commented on May 17, 2024

I think we'd be quite happy with most of that. One thing though that I remember seeing in moveit a lot is

if (a)
  b();

while I'd prefer personally

if (a)
{
  b();
}

for more consistency. Can this be added?

from ros2_control.

JafarAbdi avatar JafarAbdi commented on May 17, 2024

Seems like clang-format doesn't support this, but we could use clang-tidy to do so see

from ros2_control.

bmagyar avatar bmagyar commented on May 17, 2024

Could you please open a PR with this?

from ros2_control.

Karsten1987 avatar Karsten1987 commented on May 17, 2024

for an initial start for the clang format, does this help? ament/ament_lint#226

This at least sorts the #includes correctly.

from ros2_control.

bmagyar avatar bmagyar commented on May 17, 2024

opted for uncrustify to follow the crowd

from ros2_control.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.