ropensci-archive / vsoch

:no_entry: ARCHIVED :no_entry:

vsoch

This repository has been archived. The former README is now in README-NOT.md.

vsoch's Issues

Dependabot couldn't find the submodule /.gitmodules

Dependabot couldn't find a .gitmodules for this project.

Dependabot requires a .gitmodules to evaluate your project's current Git dependencies. It had expected to find one at the path: /.gitmodules.

If this isn't a Git project, or if it is a library, you may wish to disable updates for it in the .dependabot/config.yml file in this repo.

View the update logs.

Questions for Linux Build

hey @jeroen! I just had the first (quasi successful) build just for Linux using GitHub actions, meaning installing, testing (and obviously no deploy). Before moving on to look at the MacOS and Windows matrices, I had a few quick questions.

• After the build, could you walk me through the tasks here to upload or download artifacts? GitHub actions has it's own artifacts (what I'm using to upload checks on failure) but I'm not sure this is the same thing, or how to inspect the functions PublishPipelineArtifact@1 and DownloadPipelineArtifact@2
• Do we want / need to test coverage? I saw it in other recipes and have added it (although commented out since we need a token).

    - name: Test coverage
      if: matrix.config.os == 'ubuntu-18.04' && matrix.config.r == '3.6'
      run: |
        cd ${{ env.PKG }}
        Rscript -e 'remotes::install_github("r-lib/covr@gh-actions")'
        # TODO: Do we want to test coverage at all?
        #Rscript -e 'covr::codecov(token = "${{secrets.CODECOV_TOKEN}}")'

to me this feels like something that should be done on the level of the package repository (not here) but wanted to check.

• In the "Installing and loading binary package" step, the target was originally for a package with a long bin extension, something like <package>_<version>__R_x86_64-pc-linux-gnu.tar.gz. However in practice, this file didn't exist, but just the source did (something like _.tar.gz). Here is the code - the commented out portion is for how it was, and the next line is what I changed it to:

        # Question for Jeroen - this was originally env.PKG_BINARY but this file doesn't exist when I tested
        #R CMD INSTALL "${{ env.PKG_BINARY }}"
        R CMD INSTALL "${{ env.PKG_SOURCE }}"

Should env.PKG_BINARY exist, and if so, how is it generated? The R CMD BUILD . {{ CMD_ARGS }} didn't seem to generate it.

That's all I got for now! No rush on answering these, I know it's the holidays :) My goal is to get this working as we would expect, and then we could either test a deploy, or (probably better) would be to get the MacOS and Windows pipelines finished up first.