Coder Social home page Coder Social logo

Comments (6)

iarspider avatar iarspider commented on May 29, 2024 1

@wdconinc disclaimer: I am not part of ROOT team, so my interpretation could be wrong.

  • the change in 6.30 was intentional,
  • the change broke forward compatibility in older ROOT versions,

Yes

  • in some cases we are waiting for new bugfix releases on older versions (i.e. 6.28),
  • in other cases we are waiting for the bugfix to be merged in older versions as well (i.e. 6.26 and earlier).

I don't know if there is a plan to update older versions with this fix - in CMS we just cherry-picked the fix into our fork of ROOT.

from root.

iarspider avatar iarspider commented on May 29, 2024

@hahnjo in CMS we saw this issue as well, fixed by rebuilding old ROOT versions with this commit - a434281 .

from root.

wdconinc avatar wdconinc commented on May 29, 2024

@iarspider Did your tests indicate that this is a regression introduced by that commit specifically, or that this issue was simply not there yet at the time of that commit and it could be any commit since then?

from root.

iarspider avatar iarspider commented on May 29, 2024

@wdconinc sorry, pinged wrong person. The mentioned commit (aka PR #12845) contains the fix, but I don't know when that incompatibility was introduced.

from root.

wdconinc avatar wdconinc commented on May 29, 2024

Thanks, @iarspider. If I can summarize then:

  • the change in 6.30 was intentional,
  • the change broke forward compatibility in older ROOT versions,
  • in some cases we are waiting for new bugfix releases on older versions (i.e. 6.28),
  • in other cases we are waiting for the bugfix to be merged in older versions as well (i.e. 6.26 and earlier).

Is that an accurate summary? If so, do we have an estimate when the next 6.28 patch release will be, which will include this fix? Does this issue merit being summarized as a pinned issue at the top of the GitHub issues?

from root.

wdconinc avatar wdconinc commented on May 29, 2024

In CMS we just cherry-picked the fix into our fork of ROOT.

But that still forces everyone to use the CMS environment all the time. At our earlier stage of development, we have many users who use computing environments at clusters where we don't have control over the version installed, let alone patches installed.

from root.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.