Comments (8)
Thanks for the suggestion. I am however unsure on how it should handle the release notes, as they are 'different files', not just versions of the same file. See discussion here: #14439
See also https://github.com/sorenlouv/backport
from root.
Thanks for the suggestion. I am however unsure on how it should handle the release notes, as they are 'different files', not just versions of the same file. See discussion here: #14439
Most of the backports are fixes that are not probably worth mentioning in the release notes.
from root.
Thanks for the proposal backed up by a concrete potential solution. I like the idea of having something automated that in case of problems, simply does nothing. One thing that changes though is the squashing.
This is something to discuss. In your opinion, @vgvassilev , what do we loose by automatically squashing commits intended for backports?
from root.
Why do we need to squash the commits?
from root.
I was reading the doc of the action "It can backport rebased and merged pull requests with a single commit and squashed and merged pull requests."
from root.
I was reading the doc of the action "It can backport rebased and merged pull requests with a single commit and squashed and merged pull requests."
Ah, ok, well. At that point if we want the bot to help us we should probably do 1 commit by PR for backports. Alternatively, we can implement our own logic - should be no more than 2-3 git commands...
from root.
I think the squashing of commits is simply a change with respect to what is being done today, it's not negative or a regression per se. I even could see an advantage in having one backport per commit. A good item to be discussed in the team I guess, but this action could be really help us.
from root.
Having different granularity of commits in the main branch and the backport branch may make it harder to do forensic. For example to find out if a change/commit is present in a specific branch or when it was introduced there.
from root.
Related Issues (20)
- [df] ProgressBar reporting on number of files is now broken HOT 5
- Segmentation violation during build on ix86 (32 bit intel) HOT 7
- `THStack` does not automatically shows negative bins HOT 6
- [RF] generate method produces buggy multi-channel dataset
- [RF] Using a conditional RooProdPdf in a multi-channel fit spawns too many integrals with new CPU evaluation backend
- [RF][HS3] Higgs discovery workspaces roundtrip
- [RF][HS3] ATLAS ttbar workspaces roundtrip HOT 4
- [RF] Support for setData method in new EvalBackend classes
- [ci] Add Python version to Windows precomplied release title or filename
- Evaluate using Profile-Guided Optimization (PGO) for optimizing Root's performance HOT 9
- Where can I get arm64 linux binary build? HOT 6
- [ntuple, DAOS] maximum cage size should be part of the anchor
- JS ROOT does not draw tprofile2d correctly with "TEXT" draw option HOT 4
- root_generate_dictionary should check target OUTPUT_NAME
- pyunittests-pyroot-pyz-ttree-setbranchaddress segfaults with Python 3.13 HOT 4
- [("#root:toor, e. g. etc...")] HOT 1
- asan segfault due to declaration of function with very long return expression HOT 4
- Unintuitive behavior of `Math::PxPyPzMVector` in calculations
- Support for TProfile and TProfile2D projectionX and projectionXY options in JSROOT HOT 3
- [CI] Test produced binaries
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from root.