Coder Social home page Coder Social logo

Comments (8)

ferdymercury avatar ferdymercury commented on June 15, 2024

Thanks for the suggestion. I am however unsure on how it should handle the release notes, as they are 'different files', not just versions of the same file. See discussion here: #14439

See also https://github.com/sorenlouv/backport

from root.

vgvassilev avatar vgvassilev commented on June 15, 2024

Thanks for the suggestion. I am however unsure on how it should handle the release notes, as they are 'different files', not just versions of the same file. See discussion here: #14439

Most of the backports are fixes that are not probably worth mentioning in the release notes.

from root.

dpiparo avatar dpiparo commented on June 15, 2024

Thanks for the proposal backed up by a concrete potential solution. I like the idea of having something automated that in case of problems, simply does nothing. One thing that changes though is the squashing.
This is something to discuss. In your opinion, @vgvassilev , what do we loose by automatically squashing commits intended for backports?

from root.

vgvassilev avatar vgvassilev commented on June 15, 2024

Why do we need to squash the commits?

from root.

dpiparo avatar dpiparo commented on June 15, 2024

I was reading the doc of the action "It can backport rebased and merged pull requests with a single commit and squashed and merged pull requests."

from root.

vgvassilev avatar vgvassilev commented on June 15, 2024

I was reading the doc of the action "It can backport rebased and merged pull requests with a single commit and squashed and merged pull requests."

Ah, ok, well. At that point if we want the bot to help us we should probably do 1 commit by PR for backports. Alternatively, we can implement our own logic - should be no more than 2-3 git commands...

from root.

dpiparo avatar dpiparo commented on June 15, 2024

I think the squashing of commits is simply a change with respect to what is being done today, it's not negative or a regression per se. I even could see an advantage in having one backport per commit. A good item to be discussed in the team I guess, but this action could be really help us.

from root.

pcanal avatar pcanal commented on June 15, 2024

Having different granularity of commits in the main branch and the backport branch may make it harder to do forensic. For example to find out if a change/commit is present in a specific branch or when it was introduced there.

from root.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.