ronhasson / wikiwand-webextension

web extension port of wikiwand

Hi there 👋, Im Ron Hasson

I'm a

Developer

Contact me!

⚡ Github Stats

wikiwand-webextension's Issues

Thanks

Thanks for the port, greatly appreciated :)

Read on Wikipedia does not work

Clicking on "Read on Wikipedia" opens a new tab to wikipedia but is soon redirected to wikiwand.U

I tested on Firefox Developer Edition 58.0b12 (64-bit).

Apparently ?oldformat=true in the URL is not honored.

Wikipedia ‘Edit’ and ‘History’ links broken

Hi. Thanks for this extension — I'd been missing this functionality since upgrading Firefox a few weeks ago.

Unfortunately it's a little over-eager to redirect Wikipedia URLs to Wikiwand: it catches some links from Wikiwand that are supposed to go to Wikipedia pages.

To reproduce:

1. View an article on Wikiwand. I chose Ilkley.
2. Click on the ‘W’ icon at the top, to open the ‘Wikipedia Tools’ menu.
3. Hover the mouse pointer over the ‘edit’ menu item. Note that the URL is something like: https://en.wikipedia.org/w/index.php?title=Ilkley&action=edit
4. Click on that menu item. It opens a new tab. The extension intercepts that URL and you end up at the Wikiwand page: https://www.wikiwand.com/en/Webserver_directory_index?title=Ilkley&action=edit (where the URL parameters are ignored, so it's simply viewing the article called ‘Webserver directory index’ — who even knew there was such an article?).

There's an equivalent problem with the ‘History’ link just below ‘Edit’.

Please can you narrow down the intercepting to ignore URLs like these. Perhaps just ignore everything with a URL parameter of action=? (You could make an exception for action=view, but with normal browsing you shouldn't end up with a URL with that in it anyway (since viewing is the default action), so ignoring all action= params may be simpler.) Thanks.

Old Revisions Links Broken

Hi. Thanks for fixing #2 so speedily — really appreciated.

I've encountered another case that's incorrectly redirecting: older versions. On a history page, click on the timestamp of an older version and you get a URL like https://en.wikipedia.org/w/index.php?title=Timsort&oldid=574510695 — which doesn't have action=view in it (presumably because that's the default).

I'm now thinking that instead of filtering on action=view, it would make more sense to detect the /w/ at the start — anything under that path clearly isn't a plain article title; or conversely, only attempt to redirect paths starting /wiki/, which is at the start of all the ‘friendly’ URLs used for all normal, latest-version-of articles.

Cheers.

Re-enabling doesn't work until restarting Firefox

If this extension is disabled in about:addons, enabling it again doesn't have any effect until Firefox is restarted.

To reproduce:

1. Have this WikiWand extension installed and enabled.
2. Go to a Wikipedia URL. I chose List of animals with fraudulent diplomas. See that this extension intercepts that URL and redirects you to Wikiwand, as intended.
3. Go to about:addons, find ‘WikiWand webextension’ and press ‘Disable’.
4. Go the the Wikipedia URL again. This time it should remain on Wikipedia: disabling the extension has worked immediately.
5. Return to `about:addons’ and re-enable the extension.
6. Try the Wikipedia URL again. Unfortunately it remains on Wikipedia: re-enabling the extension hasn't worked.
7. Restart Firefox.
8. Give the Wikipedia URL one last go. Now it's intercepting properly again; restarting Firefox seems to've made the extension work again.

This is unfortunate because the workaround for Issue #2 is to temporarily disable the extension in order to edit a Wikipedia page ... but ’temporarily’ ends up meaning I'm without this extension until I'm next restarting Firefox.

What's the future?

Thank your Ron for creating this add-on even before official WikiWand add-on was ported to web extensions API. I appreciate how your proactively created this replacement instead of waiting for update from WikiWand guys.

Now that an official WikiWand add-on that supports web extensions API has been released on Nov 19, 2017, what are your plans? Will you keep supporting this add-on?