Possible bug: Icon fills PanelTab about geonbit.ui

[TN-1]

1: Correct, It was. Strange though, Because this code was working before the update.
2: If I set the size in the constructor, everything goes back to normal.
3: Handy hint, Thanks!

[RonenNess]

Thank you for the report, I'll take a look at this when I can.

Hopefully its not another obvious error on my part :)

I think I wasn't clear last time, when I said it was a "design flaw", I meant there was a flaw in the way I implemented tabs, not in the way you used them. Your code was fine :)

[RonenNess]

Alright couple of things:

1. I can't reproduce without IconI code, as it works with regular Icons. I suspect the problem is in IconI.
2. Perhaps you set the Icon's size to 0,0 in which case it takes full size of parent? Please debug and validate this, see if the icon size property is 0,0.
3. Instead of doing stuff like new Vector2(Convert.ToInt32(ScreenManager.ScreenArea.Width * .3), Convert.ToInt32(ScreenManager.ScreenArea.Height)), you can set size to new Vector2(0.3f, 0f) (size of 0 = full parent size, size between 0-1 = percent of parent).

Let me know if this was the problem.
Thanks

[RonenNess]

1: Correct, It was. Strange though, Because this code was working before the update.

Ah now I see what happened! In the last update I changed DefaultSize from being a getter to be a static property, which means in previous version it was inherited and now its not.

So in previous version when you created a class that inherit from Icon and didn't set size, it got the Icon's default size and all was well. Now it just gets 0, unless you define a static DefaultSize property in the inheriting class.

This is no good, its very confusing for people who want to create their own entities based on existing ones, like you did. I should fix it.

Thank you for the useful report, I will close this ticket when I push the fix. 👍

[TN-1]

Glad to be of assistance :)

[RonenNess]

Fixed in dev (will get in next version), thanks again for reporting! :)