ronen25 / libcmdf

Single-header library for writing CLI applications in C/C++

libcmdf's Issues

reserved identifier violation

I would like to point out that a prefix like “cmdf__” does eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

libcmdf quits prematurely

Looking at the following code in the main loop:

            /* If the buffer wasn't allocated = out of memory, so exit with failure*/
            if (!inputbuff)
                exit(CMDF_ERROR_OUT_OF_MEMORY);

That assumption is not correct. If EOF is passed, readline will also return NULL. I think the best way to handle it, is by treating it as if the exit command was called. Failure to do so, makes libcmdf shutdown the whole application without any proper way of cleaning up.

See the readline manpage:

Return Value

readline returns the text of the line read. A blank line returns the empty string. If EOF is encountered while reading a line, and the line is empty, NULL is returned. If an EOF is read with a non-empty line, it is treated as a newline. 

Completion of error handling

Would you like to add more error handling for return values from functions like the following?

• fprintf ⇒ cmdf__print_title
• fputc ⇒ cmdf__pprint