romannurik / androidsdksearchextension

A Chrome extension that adds an 'ad' omnibox command and view source links for the Android SDK.

Hi, I’m Roman. I’m a design lead on Project IDX and Firebase at Google in New York, but I also tinker with web dev and Sketch/Figma plugins. I've also done Android stuff like Muzei. See more of my work on my personal site.

androidsdksearchextension's Issues

Stopped working recently

Does not work on Chromium 32.0.1700.77

Source link broken: android.icu.*

Should go to https://android.googlesource.com/platform/external/icu/+/master/android_icu4j/src/main/java/

Missing init .js script, plugin broken!

One of SDK reference JS files is no longer available, and endlessly retry:

AndroidSDKSearchExtension/extension/background.js

Line 22 in e933077

'https://developer.android.com/reference/jd_lists.js',

Is this script required to run the plugin?

Also, it would be great to have exponential backoff on the error callback:

AndroidSDKSearchExtension/extension/background.js

Lines 54 to 57 in e933077

	function _error(script) {
	console.error('Failed to load ' + script + '. Retrying in 5 seconds.');
	window.setTimeout(init, 5000);
	}

For instance:

var backoff = 5000;

function _error(script) {
  backoff *= 2;
  console.error('Failed to load ' + script + '. Retrying in ' + (backoff / 1000) + ' seconds.');
  window.setTimeout(init, backoff);
}

Support androidx

1. Have the extension include androidx results in the omnibox search suggestions drop-down.
2. Show "view source" link on androidx documentation pages.

Item 1 is far more critical from my perspective than item 2. I pull up documentation all the time, but view the source only occasionally. So if item 1 is easy to add without adding the other, go ahead.

`android.support.test` classes missing from Omnibox

Thanks to the resolution of Issue #9, source links for test classes are much improved. However, currently nothing in the android.support.test package (Espresso, UI Automator, etc.) shows up in the ad <search term> omnibox search index.

I'm not sure if it's best for this to be added to https://developer.android.com/reference/lists.js, or to include another JS reference file in this project.

Firefox compatibility?

Would be awesome if I could use this with firefox 👍

point to the same tag as the requested api level in the url for "view source"

basically change /ref/heads/master to the right tag level found here . Its something I find myself doing a quite a bit. Also, I think professional android developers use it to compare implementations of a class at an older version of android os. This would only apply to class and resource paths if the user decides he wants to look at google source code instead of git. Adding git would be trivial.

Additions would be to...
[ ] make /refs/heads/master a placeholder and fill it in with the current api level.
[ ] register a onChange listener for that api selector dropdown
[ ] map that number to the latest tag and update the url if it changes.

Things to consider:

• new tags are added to AOSP as new rcs are made. The Android Team doesn't have a consistent rule or algorithm to determine when the the api level shifts to a new version of android. This means someone will have to go in and update the map to point to the right tag in the url. Obviously keeping current behaviour in states of uncertainty is advised.
  @romannurik , I'm curious if to see if you have ideas on this.

• What if that class is not in that level?
  Previously, this was never a problem. nothing ever gets deleted, and head tracks all things. Now it will certainly break if you attempt to view JobService in api 12 or . At the same time, there is a big warning when you attempt to toggle into a lower api level, so I say the user was warned. Otherwise, I could write a function to determine if this class is unsupported and default to master in that case.

I've completed the first two bullet points, and the second half of the last bullet point.

Show View Source if and only if source exists

It will be better to show the View Source if and only if the source file exists, it can send a HEAD request to verify if the file exists. There are lots of file URLs that return the 404 error.

Support IntelliJ's acronym-like search.

I don't know what they explicitly call this...

E.g., "VTO", "ViTrOb", and "VTreeObs" should all resolve to "ViewTreeObserver"

Support v7 Class Links Broken

Since the release of the latest AppCompat package in the support library, the source code structure has changed and all View Source links that point to classes in support/v7 do not account for the fact these files are now split by project.

Example: ActionBarActivity.java
https://developer.android.com/reference/android/support/v7/app/ActionBarActivity.html
...links to...
https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/v7/java/android/support/v7/app/ActionBarActivity.java
..but is now at...
https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/v7/appcompat/src/android/support/v7/app/ActionBarActivity.java

Thanks for all your hard work!

Can not view the source code of DexFile

No display of view source button for:
https://developer.android.com/reference/dalvik/system/DexFile.html

And there is the same issue with classes in dalvik/system package:
https://developer.android.com/reference/dalvik/system/DexClassLoader.html

GCM reference URL breaks the extension

It seems like the https://developer.android.com/reference/gcm_lists.js doesn’t exist anymore.

$ http --verbose GET https://developer.android.com/reference/gcm_lists.js
GET /reference/gcm_lists.js HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: developer.android.com
User-Agent: HTTPie/0.9.2

HTTP/1.1 404 Not Found
Alternate-Protocol: 443:quic,p=1
Cache-Control: no-cache
Content-Length: 112
Content-Type: text/html; charset=utf-8
Date: Fri, 29 May 2015 08:17:29 GMT
Expires: Fri, 01 Jan 1990 00:00:00 GMT
Server: Google Frontend

<html><head><title>404: Not Found</title></head><body><b><h2>Error 404</h2><br/>File not found</b></body></html>

Probably it was moved somewhere to https://developers.google.com/android/reference/packages, but there are no reference JS files as far as I can see.

Unfortunately it breaks the extension itself and there is an infinite “Loading Android SDK search data…” sign at the omnibox.

Please add Kotlin Reference to the SDK search

It would be great if this extension also supported Kotlin Reference docs. That way I can search the classes in both Android and Kotlin's reference docs.

https://kotlinlang.org/docs/reference/

View Source broken on android.support.test classes

On a page like:

https://developer.android.com/reference/android/support/test/espresso/assertion/ViewAssertions.html

The (View Source) link goes to the platform/frameworks/base repository, leading to a 404.

Instead, it should be looking in the platform/frameworks/testing repository. The source wasn't in the master branch, but I found it under the android-support-test branch.

how to use

Do you have instructions?

VectorDrawableCompat link to source results in 404

The documentation for VectorDrawableCompat is here: https://developer.android.com/reference/android/support/graphics/drawable/VectorDrawableCompat.html

Clicking on "view source" results in a 404: https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/graphics/drawable/animated/src/main/java/android/support/graphics/drawable/VectorDrawableCompat.java

Changing the word "animated" to "static" in the link fixes the issue: https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/graphics/drawable/static/src/main/java/android/support/graphics/drawable/VectorDrawableCompat.java

Plugin does not seem to work with latest SDK page.

I love the plugin and kept using for quite some time but it seems it does not work with latest SDK page. I'm not able to get view source link on any page.

Also searching does not lead to any results - just opens up link with https://developer.android.com/?q=xx (but from what I see currently search should be done via https://developer.android.com/s/results/?q=xx).

RecyclerView "view source" goes to wrong URL

Attempting to use the view source link on the recyclerview page goes to the wrong URL and results in a 404. Found on DefaultItemAnimator too (perhaps all RecyclerView source?)

Steps to reproduce:

• Navigate to https://developer.android.com/reference/android/support/v7/widget/RecyclerView.html
• Click the "view source" link

What should happen:

• Should navigate to https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/v7/recyclerview/src/android/support/v7/widget/RecyclerView.java

What does happen:

• Navigates to https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/v7/appcompat/src/android/support/v7/widget/RecyclerView.java (note appcompat in the URL, not recyclerview
• Page 404s

Plugin does not work for AndroidX docs

Testing with androidx.app.Fragment and no "View Source" link provided
https://developer.android.com/reference/androidx/fragment/app/Fragment.html

Do not supports other language

eg:

1. https://developer.android.com/intl/zh-cn/reference/android/view/View.html
2. https://developer.android.com/intl/ja/reference/android/view/View.html

DOM has changed

Hi Roman,

Once again the DOM of developer.android.com has changed and broke the *View Source link.
I think now you should append the link to this element <h1 class="api-title"></h1>.

Add `view documentation` to api sources

I think it would be a neat feature, if there were the ability to view documentation for documented source files.

Just the other way round as the view source option.

Doesn't work with Vivaldi

Absolutely love this extension! Tried this with Vivaldi (1.8.770.56) browser which is based on Chromium but I think it hijacks tab behaviour (boo!) Any idea how to solve it?

Thanks so much @romannurik!

pc chrome google play store

Marked as violating Chrome Web Store policy

Just tried to use the extension but it was disabled in Chrome and has a warning on the extension panel. The Chrome store page responds with 404. The extension itself works fine if re-enabled but the warning is concerning.

404 on BottomSheetBehavior

The BottomSheetBehavior link returns a 404:

https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/design/src/android/support/design/widget/BottomSheetBehavior.java

I believe this source code is not under the main Android Repository, but here:

https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/bottomsheet/BottomSheetBehavior.java

source link to grepcode.com

Is it possible to link to grepcode.com too?

The advatage of grepcode are the links to the classes and methods in a source file.

example: http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/4.3_r2.1/android/graphics/drawable/ColorDrawable.java#ColorDrawable

Source link broken: android.databinding.*

Should go to either https://android.googlesource.com/platform/frameworks/data-binding/+/master/extensions/library/src/main/java/android/databinding or https://android.googlesource.com/platform/frameworks/data-binding/+/master/baseLibrary/src/main/java/android/databinding

404 when attempting to view source of ViewGroupCompat

Clicking "View Source" on ViewGroupCompat links to https://android.googlesource.com/platform/frameworks/support/+/refs/heads/master/v4/java/android/support/v4/view/ViewGroupCompat.java which returns a 404 error.

Different shortcut

Can be the shortcut (now "ad") adjustable ? In extension preferences f.e. ?

Consider replacing regex overrides with FQCNs in the map.

This would allow doing stuff like:

"android.telephony": { .. },
"android.telephony.gsm.SmsManager": { .. },
"android.telephony.gsm.SmsMessage": { .. },

to solve #50, for example, as well as #44 and all the existing cases handled by regex.

New release?

I see several broken links in the "View Source" button, and saw a number of improvements were committed in the last couple of months.

A new release to the Chrome Web Store would be much appreciated!

Support library classes and packages should sort below framework classes.

e.g. android.support.v4.view should be below android.view.

Policy compliance issue around loading external scripts

Email from chromewebstore-dev-support:

We routinely review items in the Chrome Web Store for compliance with our Program policies to ensure a safe and trusted experience for our users. We recently found that your item "Android SDK Search", with ID: hgcbffeicehlpmgmnhnkjbjoldkfhoin did not comply with our policies. Your item was found to be suspicious and has requested/fetched one or more external scripts.

To have your item reinstated, please make any necessary changes to avoid requesting or executing remotely hosted code (including by referencing remote javascript files or executing code obtained by XHR requests). Your item is still published, but is at risk of being removed from the Web Store.

Please make the above changes within 15 days in order to avoid removal. Once you have made these changes you may submit and publish a new draft in the developer dashboard. Your draft will be reviewed for policy compliance which typically takes a few business days. If the outcome of the review is successful, your store listing will remain published. If we find additional issues with your item, we will send you another email with details. If you have any questions about this email, please respond and the Chrome Web Store developer support team will follow up with you.

Important Note:

Your item will still be subject to review and may be removed from the store within the warning period. Repeated or egregious policy violations in the Chrome Web Store may result in your developer account being suspended or could lead to a ban from using the Chrome Web Store platform. This may also result in the suspension of related Google services associated with your Google account. Thank you for your cooperation,

Source links broken: android.telephony.*

Two types have moved to https://android.googlesource.com/platform/frameworks/opt/telephony/+/master

Search result improvement. R.String is preferred over lang.String

Hello,

If I search for String then R.String is preferred over lang.String even though, I would hope, lang.String is more visited, useful, and desired.

Is there a specific reason for preferring R.String over lang.String and if we could improve the results that would be great.

Thanks.

jd_lists.js is 404'd

https://developer.android.com/reference/jd_lists.js

Show

"View Source" option no longer showing with most recent Android documentation.

I was using the extension today, and I noticed that the "View Source" option no longer shows up with the latest documentation redesign. I attached a screenshot:

Plugin appears totally broken after recent update to developer.android.com

I was planning on looking into it. Not just being a nag but I wanted to raise some noise.

Source links broken: android.test.*

Combination of https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/test-mock/ and https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/test-runner/