Coder Social home page Coder Social logo

Comments (5)

mbostock avatar mbostock commented on May 17, 2024

Actually, it doesn’t have anything to do with the file names. Here’s another example:

foo.js:

function thing() {
  return "I am thing!";
}

export default function() {
  return thing();
};

bar.js:

import thing from "./foo";

thing();

This has the same problem. I can work around by renaming thing in foo.js to thing_foo or thing in bar.js to thing_bar.

from rollup.

caridy avatar caridy commented on May 17, 2024

a couple of notes here:

  • default function should be hoisted in case some other module imported it in a circular fashion.
  • synthetic identifier for a default export function, or class, should probably be named accordingly, something like: _foo_$default_ or something like that, to avoid collision with named exports in the same module.

from rollup.

mbostock avatar mbostock commented on May 17, 2024

Thanks for the fast fix.

from rollup.

Rich-Harris avatar Rich-Harris commented on May 17, 2024

No problem - released as 0.8.1. @caridy Thanks for spotting that subtle point re hoisting - the new behaviour is that anonymous function expressions are converted into named function declarations (I figured that was easier than worrying about manually hoisting the definition).

from rollup.

caridy avatar caridy commented on May 17, 2024

👏

from rollup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.