rokka-io / rokka-go Goto Github PK

(Not just a JSON output anymore)

• By default CLI commands return a nicely formatted, human readable output
• A flag is supported to retrieve the JSON response (e.g. -raw)

See rokka-io/rokka-site#65 for docs.

• contact GitHub to request that feature.
• rename download binaries to something user friendly.
• put download link on readme
• put binaries in ZIP archive and chmod +x the binary

Searching sourceimages can be done on various fields in various ways. How we currently implement it is that you can pass a string for each of those values and define on your own whether you want to use a range or just a value.
This is not very typesafe and could be made easier by the library. Question is: is it worth the effort?
An example of how we could implement that for the string type (untested code):

type MaybeRangedString struct {
	Val string
	Range RangedString
}

func (mrs *MaybeRangedString) EncodeValues(key string, v *url.Values) error {
	if mrs.Val != "" {
		v.Set(key, mrs.Val)
		return nil
	} else {
		return mrs.Range.Encode(key, v)
	}
}

// RangedString is a string with from and to values.
// FromExclusive/ToExclusive define how the query string range is passed.
//
// From needs to be set always.
type RangedString struct {
	From          string
	To            string
	FromExclusive bool
	ToExclusive   bool
}

// EncodeValues implements query.Encoder for custom range encoding.
func (rs *RangedString) EncodeValues(key string, v *url.Values) error {
	s := ""
	if rs.FromExclusive {
		s += "{"
	} else {
		s += "["
	}
	s += rs.From
	if rs.To != "" {
		s += "," + rs.To
	}
	if rs.ToExclusive {
		s += "}"
	} else {
		s += "]"
	}
	v.Set(key, s)

	return nil
}

Similar implementations would have to be provided for the other types, though some things can probably be reused accross the types.

Opinions?

rokka-io/rokka-site#64

Todo still:

• Add/Delete User metadata on source images (#36)
• Delete sourceimages (#37)
• Delete source images with binary hash (#37)
• Download a source image (#37)
• Delete a stack (#38)

chregu@pri14:~/tmp$ rokka stacks delete $YOUR_ORG test
Stack successfully deletedchregu@pri14:~/tmp$

There should be a new line after "deleted"

https://github.com/commitizen

See https://rokka.io/documentation/references/stacks.html#updating-existing-stacks

rokka-io/rokka-site#64

to be able to immediately open the sourceimage in the browser and see how it looks like.
Probably needs some way to use the image host to generate the URL. May not be possible just with a template change.