roice3 / magiccube5d Goto Github PK

Visual Studio has deprecated/removed support MSI installer vdproj files. An alternative for installation will have to be found. While I do not know much about the topic at present, I believe that Windows Forms solutions can make an installer from the project properties now.

License headers are a standard practice with most licenses. While the MIT license (used with this project), does not require this, I'd like to still see it there.

Proposed header format:

// <copyright file="%FileName%" company="R3 Productions">
//     Copyright (c) 2008 Roice Nelson, Nelson Garcia. All rights reserved. Licensed under
//     MIT License. See LICENSE in project root for full license information, or visit
//     https://opensource.org/licenses/MIT
// </copyright>

• I am using a Visual Studio extension that removes trailing whitespace in code. I've noticed several lines have it and I would
  like to remove it if that's okay.
• Tabs and spaces are mixed in the source files. I would like to replace all tabs with four space indents.
• I'm not sure if there is a defined coding style for this project. If not, I would like to propose Google's clang-formatted styles,
  with 88 character line limits. Here is my proposed .clang-format file:

---
Language: Cpp
BasedOnStyle: Google
ColumnLimit: 88
IndentWidth: 4
AccessModifierOffset: -4
SortIncludes: true
ConstructorInitializerIndentWidth: 8
ContinuationIndentWidth: 8
DerivePointerAlignment: false
MaxEmptyLinesToKeep: 2
...

From a user:

I was playing around with your magic cube 5d, attempting to solve it. I was making macros for particular tasks, and after finishing one such macro, I tested it out. After performing the macro three times on the solved cube, it would be brought back to its original, solved, state owing to the nature of the macro in question - which it did. This also, however, caused the program to believe I had just solved the cube and made a message pop up saying so, telling me I should send my log file to you, among other things. But I did not in fact solve the cube, at least not yet, as to truly solve it requires it to be solved from a fully scrambled position (of course).

So, I thought I would notify you about this, and send my log file, so that you might be able to fix this so other people don't run into the 'solved' message when they shouldn't. (Rather spoiled a nice surprise for me, but the real surprise for me would be solving this monstrosity, so I don't really mind)

Standard repository layout is to have root src, test, and doc folders, each containing files implied by each name. This helps reduce clutter if more projects are ever added (which I will be doing to separate the native and managed C++ code).

In short, I'd like to put all code in the root namespace roice3 (for C++) and Roice3 for C#. My rationale is that all projects/repositories should ideally be in a universal namespace of the company. This helps better identify where the code came from, and minimizes any possible clashes from developers who may use this code for their own projects.

Currently, this project is using OpenGL's outdated compatibility mode, which has been deprecated since GL3. It would be a big change, but I'd like to see the render logic moved to core profile. This would offer significant improvement in performance (a necessary step for people like myself who see the 7^5 lag).