rodrigopedra / clearsale-id Goto Github PK

• Version: v0.5.0
• PHP: 7.2.33

Description

While this library works with PHP >= 5.6 and <= 7.1, we can have problems when working in an environment running PHP versions ^7.2 because it introduces a breaking change about the count() method

In PHP versions prior to 7.2, calling count() in not countable elements, would return falsy values, after 7.2, an E_WARNING is emitted.

Parameter must be an array or an object that implements Countable in %s on line %d

The best way to fix this, is by abandoning support for PHP lower than 7.1, while using short circuit for cases where count is called for a nullable value OR by casting the value to array:

if ($this->phones && count( $this->phones ) > 0) {

Opa, beleza?

Qual a diferença da modalidade ClearSale ID em relação a modalidade utilizada na lib https://github.com/lucasmro/ClearSale/tree/master/docs ?