Coder Social home page Coder Social logo

rocket.chat.kotlin.sdk's Introduction

Rocket.Chat.Kotlin.SDK

rocket.chat.kotlin.sdk's People

Contributors

alexfdz avatar aniketsingh03 avatar leonardoaramaki avatar luciofm avatar mariusvolkhart avatar philipbrito avatar rafaelks avatar samrmur avatar shailesh351 avatar shriakhilc avatar shubhsherl avatar tannerjuby1 avatar ubarsaiyan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

rocket.chat.kotlin.sdk's Issues

[BUG] Wrong JSON key used for lastModified in Subscriptions.kt

The lastModified field is mapped to the lm key in the Subscriptions.kt file here. Both the documentation and the actual response received use the ls key.

I can send a PR, but since it's a tiny change it might be better to simply include it in a soon-to-be-merged one.

[FEATURE] Support for login with email

Presently the SDK supports login only with username. In order to support login with email, the payload needs to be built with the key user as mentioned in the api docs instead of username which has been used currently(see here) for supporting login with username.

Are you willing to work on this?
Yes

[NEW] Rest api call for getting all members of a channel

Presently, the SDK does not have any rest call for fetching all members of a particular channel. In order to do so, a rest call needs to be made to the api endpoint /api/v1/channels.members with the params roomName or roomId and api headers X-Auth-Token and X-User-Id.

Are you willing to work on this issue?
Yes

[BUG] JSON Format for Profile Update

While working on an issue for the Android Native application, I noticed an error (See #762 for an example of this error produced by aniketsingh03) that popped up when a user would attempt to update their profile. From reading the documentation for the REST API, it looks like the payload is being delivered incorrectly. The API specifies that data should be delivered in this format:
{"userId": "BsNr28znDkG8aeo7W", "data": { "name": "new name", "email": "[email protected]" }}
However, the SDK appears to be delivering the data in this format:
{"userId": "BsNr28znDkG8aeo7W", "name": "new name", "email": "[email protected]"}
I observed this behaviour while looking through the LOGCAT for the Android 2.0 App

Possible Fix
Since UserPayload is also used when signing up, it can separated into SignUpPayload and UpdatePayload.

Willing to work on this issue
Yes

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.