robwhitaker / mmp-website Goto Github PK

Starting at page 1 (Chapter 1 beginning) and clicking the Forward button very fast, I progressed to the beginning of Chapter 2. Once the page loaded up, the page counter at the bottom said "1 / 0" which breaks the rules of math. Clicking forward once brings me to the front of the book, closed cover. Clicking the cover brings me to the beginning of Chapter 1 again, and everything is fine now.

Reproducible: not sure. I tried a second time and everything loaded perfectly fine.

Browser = Opera Developer v 39.0.2234.0, fullscreen'd

Possibly load low-res images while loading larger images in the background.

On render/reflow, determine the current position of all elements in book, and store it in a hash. Thus, no DOM checking has to be done on page turn / jump.

Browser: Safari (probably on any browser but this happens to be the one I was on)

The long dash at the end of the first line of The Eyeball is brought to its own line if the page wrap happens on the word "and".

I resized to be sure that there wasn't a space between "and" and the dash, and there is not. So it should probably remain attached to the word "and". Then again, this might not be in your control, or maybe it's not actually a problem. I just don't think it looks good.

On slow connections, this will hopefully cause a close-to-immediate display of all images in low resolution while the high resolution images load in the background, making the site immediately usable.

Specifically in calls to the Renderer or other parts that could fail.

Reproducible in local Chrome 54.

Fixed with the dank try catch block:

function refreshCommentCount(forceFF) {
    if(isFirefox() && !forceFF) return; //hack because Firefox is broken
    try {
          if(!(DISQUSWIDGETS && DISQUSWIDGETS.getCount)) {
              console.log("Error: DISQUSWIDGETS not defined.");
          } else {
              console.log("Refreshing comment counts.");
              DISQUSWIDGETS.getCount({reset: true});
          }
        } catch (e) {
          console.log("dingle mccringlson");
        }
    }
}

The text should be vertically centered (level with the arrow), not pushing against the bottom of its container. This only seems to occur on my desktop. Browser and window size don't seem to matter.

In chrome, when zooming, sometimes something like this briefly flashes for a second before correcting itself.

Get rid of it yo

This doesn't occur when the flex styles on the modal div are disabled. Somehow, the external flex container affects the div properly when it isn't set to be treated as a flex element. Of course, disabling the flex styles breaks the positioning in every other browser.

Opera Developer 39.0.2234.0

1. Clicked on dropdown heading for Episode 2-2A-6
2. Did keyboard shortcut to instant change size of window (shorter)
3. "&nnbsp;" shows up at beginning of paragraph in section 6
4. Resized back to full-screen and it's still there
5. Turn page backwards, turn forward again, text is still there
   

sendmail is configured, need to test email sending on error

https://github.com/robwhitaker/MMPWebsiteV2/tree/error_emails

Before zoom:

After zoom:

Sometimes the editor cookies ends up having its extra details appended to it.

Patch notes: 2.3.2 | 2.3.3 | 2.4.0

2.4.0 runs just fine locally. Deploying, not yet successful.

• @larouxn

Probably not a huge issue but things get funky, Chrome at 500%

And Chromodo at 300%

Tested on an iPhone 6S Plus running iOS 9.something.

Currently we install all gems at during deploys and we don't need any dev gems on staging or production. We only need to install only production and general gems.

• Note: currently completely untested in desktop Safari

Possibly create a mailing list and share on social media to gather participants.

So, the Halloween part opens in the reader but its super difficult to navigate and terrible

Also at this point you can't navigate anywhere else.

Collision detection based on getBoundingClientRect, which is known to be bugged with CSS column layouts in Chromium. https://bugs.chromium.org/p/chromium/issues/detail?id=362232

Margin/padding wraps to previous page with CSS columns causing IE to think the elem starts a page before it does. This affects jump navigation as well as page turns back, which don't indicate the proper selected segment.

"needs to be refactored with a sweet stack" ==> Fix structure to RSS standards

Browser: Safari.

Just writing this as some info, not really something you can fix.

When you Cmd-Plus or Cmd-Minus the page in Safari, the default behavior is to zoom the whole damn page like it's a still image. Observe:

The way to turn this off is to go to the View menu in the browser, and toggle the option "Zoom Text Only." Now it works like a normal browser. Lel.