Coder Social home page Coder Social logo

Migrate to robotology about osqp-eigen HOT 13 CLOSED

robotology avatar robotology commented on June 12, 2024 1
Migrate to robotology

from osqp-eigen.

Comments (13)

traversaro avatar traversaro commented on June 12, 2024 2

I think osqp-eigen is the most descriptive one, if you want to have c++ in the name I would go for cxx or cpp to avoid strange corner-case problems with having + in the package/repo name.

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024 2

Since #5 and #7 were merged and the license was updated (now LGPL 3) we can move this repository to robotology.
@DanielePucci @S-Dafarra @traversaro

from osqp-eigen.

S-Dafarra avatar S-Dafarra commented on June 12, 2024 1

Maybe when migrating we could change Optimizator* to Optimizer* 😉 .

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

Ok, as regarding the name of the repo what do you prefer?

  1. osqp-c++;
  2. osqp-eigen;
  3. osqp-c++-eigen;
  4. ...

from osqp-eigen.

traversaro avatar traversaro commented on June 12, 2024

The osqp-something naming scheme is also compatible with the names of the repositories of osqp bindings for Python, Fortran and MATLAB: https://github.com/oxfordcontrol .

If you want visibility for the library, once you are a bit confident that the API interface is stable (ish), you could propose to OSQP's authors to include the link to this Eigen interface to OSQP in the OSQP Interfaces page: http://osqp.readthedocs.io/en/latest/interfaces/ (there are already some 3rd-party interfaces such as cutest).

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

Ok the name of the repository will be changed into osqp-eigen. The master branch is fully tested while, in the next few days, I will write some tests for the devel_update_matrices branch.

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

Maybe when migrating we could change Optimizator* to Optimizer* 😉 .

Done! 😄

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

Porting can be performed when this issue will be closed.

from osqp-eigen.

ahoarau avatar ahoarau commented on June 12, 2024

@traversaro You are everywhere I look ! 😃

Question : Isn't the default licensing for robotology LGPLv2-3 ? I'd like to use this but not put my code GPL

from osqp-eigen.

traversaro avatar traversaro commented on June 12, 2024

Hi @ahoarau !
Yep the software is licensed under LGPL2/3, the content of the LICENSE file will be changed soon, thanks for pointing that out.

from osqp-eigen.

S-Dafarra avatar S-Dafarra commented on June 12, 2024

Just a couple of suggestions before migrating to robotology.
Maybe it is better to rename the files from Optimizer* to OsqpEigen*, to make clearer the inclusion of these files in external projects. In addition the name OptimizerSolver seems a repetition.
Another option could be to remove Optimizer* from the file name and place them all in a folder called OsqpEigen, so that the inclusion would seem like:

#include <OsqpEigen/Solver.hpp>

instead of

#include <OptimizerSolver.hpp>

I would suggest also to change the name of the namespace from OsqpWrapper to OsqpEigen to preserve consistency with the project name.

I can deal with these modification if you like, maybe adding them to https://github.com/GiulioRomualdi/osqp-eigen/pull/5.

Clearly this would break the code which has been written according to the current version, but it may be reasonable to change it when migrating organization.

from osqp-eigen.

GiulioRomualdi avatar GiulioRomualdi commented on June 12, 2024

I think we can close this issue.

from osqp-eigen.

traversaro avatar traversaro commented on June 12, 2024

Yeah!

from osqp-eigen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.