robertmain / maestro Goto Github PK

The app currently depends on native ffmpeg. Ideally, it should use static binaries to make it easier to install - especially for people without admin access to install things.

Attempting to play a file that doesn't exist results in an ffmpeg error (rather than a custom error giving more detailed insight into the problem

We are currently using fs.existsSync to check if a file exists on disk or not. This is not ideal as it's thread blocking.

Platform

OS: Windows
Node Version: 10.4.0
NPM Version: 6.1.0

Any Additional Info

Proposed solution

const { promisify } = require('util');
const stat = promisify(fs.stat);

We seem to be using two different mocking libraries - TypeMoq and mock-require. Really we need to condense this so we don't have loads of dependencies because it's messy. :)