robertladwig / lakemodelr

R package to run a modularized 1D integral energy model for water temperature dynamics in a lake

Visit my homepage or follow @hydrobert on Twitter.

Recent releases metabolism-phenology v0.3 L&O - 2022-03-16 thermod v1.0 forecasting - 2021-06-09 salinizaition-lakestratification v0.9 L&O letters submission - 2020-06-09 lakeensemblr v1.0.0 - 2020-10-28

How this works

lakemodelr's Issues

Idea regarding the "greeting" message?

Not an issue but an idea I had when I saw the greeting message "What a beautiful day to run a lake model."!
(oh no, is it the GitHub version of conferences' "I have more of a comment than a question")...

Since it appears that the tool has vocation to be educational too, you could have different greeting messages coming in. To achieve that, you could have a table with as many rows as potential messages. For example:

greet	bye
"What a beautiful day to run a lake model."	"Have a lovely rest of your day!"
"What is the deepest lake in the world?"	"Lake Baikal (5,315 feet [1,620 meters])"

If you define the table above in your script, you could sample in this dataframe a row from the "greet" table to have several messages every time the model is run?
I forked your repo and edited the script to explain the idea if you end up wanting to do that...

Good job, this is a great tool!

Package dependencies for example.R

I got loadnamespace errors, needing packages pracma and RLakeAnalyzer to run the code. Need to list those as additional imports?

Can't find k600.2.kGAS.base() - Issue when trying to run the model with water quality

When water.quality = TRUE in run_thermalmodel(), I get the message:

Error in k600.2.kGAS.base(k.vachon.base(wnd = WIND, lake.area = max(AREA)), :
could not find function "k600.2.kGAS.base"