robbinhabermehl / gulp-angular-translate Goto Github PK

In the source code: file.path.split('/')

This does not work in Windows where \\ is used as the path separator. Maybe using something like this: file.path.replace(/\\/g, '/').split('/')

According to http://angular-translate.github.io/docs/#/guide/08_fallback-languages it would be useful feature an ability to add language fallback in the end of $translateProvider.translate(...) chain.

Steps to reproduce:

1. Create a gulp task.
2. Create a JSON file with "tkey.json" name and save it.
3. Point gulp.src at the file's location.
4. Do not add any "options.language" configuration.
5. Run the gulp task.
6. Notice console.

Result:

Running the task will output an error:

TypeError: Cannot read property 'pop' of null
at <DIRECTORY PATH ...>\node_modules\gulp-angular-translate\index.js:11:130
.......

Additional notes:

Reported the bug in case others encounter the issue.

Hey,

I am facing a weird case, I am running the task to concat all the strings and a translations.js file, but for some reason when I update a string the value in translations.js still the old one, I have tried to delete the file with "del" without success.

When I change some value and concat again with task the values are updated.

It seems a kind of cache, any idea about this ?

Error: Cannot find module 'gulp-util'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/repos/esl-html-mobile/node_modules/gulp-angular-translate/index.js:3:13)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

When installing through npm, the package.json is missing gulp-util as a dependency. The gulp task doesn't work without it.

When I add the dependency and run npm install again, it works.

"dependencies": {
    "event-stream": "3.1.7",
    "gulp-concat": "2.4.2",
    "gulp-util": "3.0.1"
  }

Could the concatination of the files be made optional? I'd like one angular-module-file for each language.

Example:

translation-en-US.json ==> translation-en-US.js
translation-de-DE.json ==> translation-de-DE.js

I personally prefer to name my translation files like someName-{locale}.tr.json instead of someName-{locale}.json, (Which by the way I recommend to you too :D).

Your assumption that the naming translation files adhere to your standard is too restrictive.
You should allow "*/.json" to be globbed.
Want me to make a pull request?