robbiethewagner / angular-styleguide-es6

Angular Style Guide ES2015/ES6: A starting point for Angular teams to provide consistency through good practices.

angular-styleguide-es6's Issues

Broken link

From [Style Y075]:

Note: Regarding dependency injection, see Manually Identify Dependencies.

Not sure if this section still exists or has an analog in this fork...

Component guide

Nice abstraction of original guide to ES6 format.

How about including a section for Angular Components (those introduced in 1.5)

I have a nice abstraction convention myself, but would be curious how it compares to others.

Invalid image urls

@rwwagner90 Images have invalid urls. Please check pull request #11

Use of Angular setter getter

I think using the setter/getter can be permitted but only once at the entry point of ones app. With the ES6 module syntax you can load your components and pass the angular app variable as an argument. It makes your code really modular that way.

Example from my ES6 Webpack Example:

const app = angular.module('app', ['ui.router']);

// Components Entrypoint
appComponents(app);

// Common Components Entrypoint
commonComponents(app);

// App Services Entrypoint
appServices(app);

non-working "reccomended" example

y022

/* recommended */
angular
    .module('app')
    .controller('SomeController', SomeController);

class SomeController {
  constructor() { }
}

ES6 classes are not hoisted as I understand it, and as such, this example will not work. SomeController will not be defined here before it is used.

factory example is not complete

Hello,

I think this snipped out of your docs doesn't work at all:

/* recommended */

// dataservice factory
angular
    .module('app.core')
    .factory('dataservice', dataservice);

class dataservice { 
  constructor($http, logger) {
    this.$http = $http;
    this.logger = logger;
  }
  getAvengers() {
    return this.$http.get('/api/maa')
      .then(getAvengersComplete)
      .catch(getAvengersFailed);

    getAvengersComplete(response) => {
      return response.data.results;
    }

    getAvengersFailed(error) => {
      this.logger.error('XHR Failed for getAvengers.' + error.data);
    }
  }
}

A service is not able to take a class constructor. I used .factory('dataservice',() => new dataservice()) but then this.$httpwould be undefined...
Any idea how to solve this?
Cheers

No mention of exports

import is described, but not export. For consistent placement, it should be documented. Perhaps at the bottom of the file, rather than inline per declaration.