robaxelsen / robaxelsen.github.io

This repository does not have a main page, but contains subfolders to host and share portfolio projects and demos.

Robeerob's GitHub Pages repository

This repository does not have a main page, but contains subfolders to host and share portfolio projects and demos.

List of projects currently hosted here:

1. JavaScript Calculator
2. Pomodoro Clock
3. Tic Tac Toe Game
4. Simon Game

robaxelsen.github.io's Issues

Jumbotron div too wide on desktop

Jumbotron class too wide on desktop.

See screenshot:

Fix navbar not being mobile friendly

Currently the navbar's width is too wide on mobile. The behavior should be that it follows current bootstrap col-sm width. Check if putting nav outside container helps. If not, look into how to size it with appropriate bootstrap class or css.

Remove top margin on smallest screens

Currently jumbotron has no side margins, but margin on top. Remove margin on top to make it look better on mobile.

Fix bug with possible duplicate input of division operator

It is currently possible to input duplicate division ('/') operator. Needs to be fixed in num-button click listener function.

Disable scrolling and zooming on mobile view

Svetlozar Kalchev posted on FB:
"Nice! I would disable scrolling and zooming, however. I can scroll and zoom on iOS in Safari. Don't know if this happens on Android."

Add function for equal button

Menu right margin issue on mobile view

After fix to issue #2, we now have a problem with a right side margin issue for menu on mobile.

See screenshot:

Rearrange buttons and implement pointer cursor.

From Otto Lache on FB:
Works pretty nice =D
Some things I personally would favor: I'd prefer it if the operations would all be in the same column (see picture below) to make it more clear structured. Also a little detail would be the cursor:pointer for the buttons ;)
(Edit: I wouldn't use a digit as the beginning of an id. It wasn't allowed in HTML4 but is in HTML5 so I guess it's up to you how you do it ^^)

But all in all a nice and clean Calculator!

Picture:
https://goo.gl/photos/sjt78BEhusYpisoU6