Coder Social home page Coder Social logo

Comments (7)

strips avatar strips commented on August 20, 2024 1

I have forked the repo and might create a PR if I get it working satisfactory. Keeping the default config folder and adding a make install CONFIG_PATH= parameter. I'll write something on the readme as well.

from spyglass.

mryel00 avatar mryel00 commented on August 20, 2024

Hey, thanks for the hint to this.
We started this project for the 3D printing community, for klipper and moonraker machines to be precise.
Imo this should stay the main target and therefore the default directory of ~/printer_data/config should stay like this. A check for the directory and the creation if it doesn't exist, can make sense.
Another option might be to check for the ~/printer_data/config directory and if it doesn't exist, create and use the /etc/spyglass directory.
@roamingthings what's your opinion on this?

from spyglass.

roamingthings avatar roamingthings commented on August 20, 2024

Since Spyglass is targeted at Klipper which has a fixed filesystem layout I would not change the directory by default. In the other hand I'm happy, if this project is of any use outside the Klipper universe.
Can we find a solution that keeps the current folder as a default and allows it to be changed as an option?

from spyglass.

mryel00 avatar mryel00 commented on August 20, 2024

You mean e.g. make install INSTALL_DIR=/foo/bar?

from spyglass.

strips avatar strips commented on August 20, 2024

Thanks for the explanation. I'm actually intending to use this for Duet (RRF) to serve video / photos for 3d printing :)

If this software is targeted for Klipper I would suggest a change in the description of the software.

Maybe changing this in the readme, "A simple mjpeg server for Picamera2." to "A simple Picamera2 based mjpeg server for Klipper." At least some text so people get where the software is coming from and it's intended use. Then adding a line to say it can also be used standalone.

from spyglass.

mryel00 avatar mryel00 commented on August 20, 2024

You are right. I thought there was maybe already a section like that, until your post.
The README and installer need both an update anyway, but no one had time for it yet.

from spyglass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.