Coder Social home page Coder Social logo

conflatao's Introduction

Das neue Contao BE Theme

Hier entsteht ein neues Contao 3 Backend Theme im Rahmen meiner Bachelorarbeit. Soweit vielen Dank an die Contao Community. Ich freue mich sehr über das viele positive Feedback, das aufgebrachte Engagement und das Interesse!

conflatao's People

Contributors

marcobiedermann avatar ro-a-fi avatar ciaobello avatar

Stargazers

 avatar Niels avatar mk-solutions.ch avatar Markus Krause avatar Ben Richter avatar  avatar Kay Spiegel avatar Richard Thiel avatar Peter Ongyert avatar Hannes avatar Marcel Engelmann avatar  avatar  avatar  avatar Sebastian avatar  avatar Christian Barkowsky avatar David Enke avatar Florian Biebel avatar Malte Bublitz avatar  avatar Pavel Kuzma avatar

Watchers

Michael Schuh avatar Gion-Andri Cantieni avatar Stephan Jahrling avatar  avatar Ben Richter avatar  avatar  avatar mk-solutions.ch avatar

conflatao's Issues

Coding Style: Tabs or Spaces

I suggest to build everything upon one coding style. Do you prefer tabs or spaces and how much do you like to indent them?
I always use two spaces for css because this is the recommendation from Google and SassGuidelines. Yeah, this topic is a debate on it's own but because you are the creator, what do you like more?

Hope this is ok, that I am pushing forward but maybe this theme might end up being in Contao 4.0 :D

core styling

Add styling for core elements:

  • accordion
  • download
  • gallery
  • table
  • text
  • images
  • pagination

missing indent of nested folders in the file management

There is an missleading or missing indent of folders that are nested. This occurs only in the lightbox window when accessing files via a content element.

In the Screenshot below the "layout" folder is actually nested in "images".

bildschirmfoto 2015-06-05 um 23 17 01

Relative Units

Hey, how do you like relative units? Currently everything is coded in px.
I personally use rems since a few months. Before I used ems but rems work a bit nicer. The benefit of this technique would be that everything builds upon a base size. I suggest using e.g. 14px ~ 0.875rems and use multiples / divisions for spacing. E.g. .25rem, .5rem, .75rem, 1rem, 1.5rem. This will be a more consistent approach and also be very simple to code.
The only downside of rems is that it is only supported in IE9+. My go would be using rems with a fallback of px so it is easy to drop IE8 support in the near future.
Of course this will cause that the theme looks slightly different but I think this is a more consistent way. Also the big benefit of this is that it will scale according to the browser settings. If the user changes the default text size to e.g. 24px everything will scale up.

clean up colors

Currently there are way to many different colors in use. You pretty much can not tell any difference between them, so my suggestion is to limit these. This will help us to maintain the project better and saves some bytes if gzip is activated.
@ro-a-fi Are you okay with that?

Sass Support

Hey Raphael,

I really like this theme and would help you with it, if you want to.
My suggestion is to code it in Scss instead of regular CSS, so we can take advantage of variables for spacing and colors, functions and loops. This way, everything is more dynamic and consistent.
If you agree, I can take care of this and send you a PR :)

remove platform specific styles

I suggest removing platform specific styles like webkit, firefox, safari, opera, ie and js.
Use some browser normalisation instead.

dripicons

Can we remove src/dripicons? They are not used in the theme.
Iconfonts are not the best solution for an icon system. Best way would be to use an SVG iconsprite but unfortunately this is not supported by Contao. I think using pngs for now is the best solution.

Webfonts: License and Loading

Are we allowed to include Source Sans Pro in the project? I am a bit confused.

Google Fonts repo:

WARNING: NOTE THAT ONLY GOOGLE INC MAY DISTRIBUTE MODIFIED VERSIONS WITH THE TRADEMARK NAME "SOURCE" and only then with approval

Wikipedia:

It is the first open source font family from Adobe, distributed under the SIL Open Font License.

Fontsquirrel:

The OFL allows the licensed fonts to be used, studied, modified and redistributed freely as long as they are not sold by themselves.

So I think it is ok to include it into the project but I am not 100% sure.
If we have the permission I suggest to generate and only serve woff and woff2 because they are supported by mostly any browser (~90%). Older browsers which do not support woff also lack on supporting other features so in my opinion it is ok to fall back to a system font. Old browsers will not have to download heavy fonts with this way of serving the font.
If we want to get a bit further we can load the font async and store it in localstorage. I've done some tests and this works really well

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.