rnorth / duct-tape Goto Github PK

The documentation link present in the README points to http://rnorth.viewdocs.io/duct-tape/.
Here some kind of error page is displayed:

If an exception is thrown in
public static <T> T retryUntilSuccess(final int timeout, @NotNull final TimeUnit timeUnit, @NotNull final Callable<T> lambda)
it will be wrapped into a TimeoutException.

It might be necessary in some cases to abort execution immediately on some exception, which is not possible at the moment.
One possible solution is to add an optional exception handler argument - Consumer<Exception> handler, that would just rethrow the exception here:

try {
                        return lambda.call();
                    } catch (Exception e) {
                        // Failed
                        LOGGER.trace("Retrying lambda call on attempt {}", attempt[0]++);
                        lastException[0] = e;
                    }

Hello!

Would it be possible to mark the dependency to org.jetbrains:annotations as provided or optional?

We had trouble upgrading to the latest Testcontainers release because the very popular org.jetbrains.kotlin:kotlin-stdlib also depends on it, leading to various modules to fail the build becuse of dependency convergence problems.

I can of course exclude it so it's not big deal, but I'm reporting it as it might be just easier for all Testcontainer users if this wasn't pulled in.

Thanks

org.rnorth.ducttape.timeouts.Timeouts starts an executor service using non-daemon threads. Any use of the Timeouts class consequently prevents the JVM from exiting normally - it has to be interrupted.

Unreliables.retryUntilSuccess is currently implemented so that the worker thread never stops calling the lambda if the future times out.

PR: #5

The LICENSE link on goes to Page Not Found
http://rnorth.viewdocs.io/duct-tape/