rm-rf-etc / lektor-remote Goto Github PK

I've made it through your manifest, taking my first steps in Docker groan, got everything up and running. It works! Thanks alot, @rm-rf-etc !

Some points (which might be silly newbie ideas), all around the softinstigate/lektor image and creating a clone from and making it more generic:

• isn't it better Docker practice to e.g. docker pull node, instead of the whole curl, yarn and apt-get thing?
• wouldn't it, instead of FROM python:2.7, suffice to use a slim or alpine image in order to save space?
• including webpack would be great, and other Lektor plug-ins too
• don't know if I've understood Docker well enough, but wouldn't it be cool to have a set of images with different plug-ins included, and select which one to pull in the docker-compose.yaml file? In a similar way as the different python versions are managed

In the "Helpful commands" section I'd add that in order to restart the Lektor server you have to repeat docker-compose up instead of lektor server or something like that. It took me while to figure out.

(I'm also a GitHub newbie - is raising an issue the right way to tell what I've just said?)