underscore (_) in branch name is replaced with dash (-) about github-slug-action

[rlespinasse]

The rules are in this section : https://github.com/rlespinasse/github-slug-action#overview
The implementation is defined on https://github.com/rlespinasse/github-slug-action/blob/v3.x/src/slug.ts
The test suites are in :

• https://github.com/rlespinasse/github-slug-action/blob/v3.x/__tests__/slug.test.ts
• https://github.com/rlespinasse/github-slug-action/blob/v3.x/__tests__/slugref.test.ts

[rlespinasse]

Make sense for _SLUG variables.
For _SLUG_URL variables, the current rules will remain the same.

[TSMMark]

I could send a PR if you point me to which lines to update and what specs + doc updates you would need

[TSMMark]

So I will at minimum be updating this test case:

github-slug-action/__tests__/slugref.test.ts

Lines 38 to 41 in 6c93fcb

	test('slug_ref: a reference with upper case letters', () => {
	test_slugref('refs/heads/New_Awesome_Product', 'new-awesome-product')
	test_slugref_cs('refs/heads/New_Awesome_Product', 'New-Awesome-Product')
	})

Are we concerned about changing this and possibly breaking users' workflows? Or you think if they're specifying the action version properly we could rely on semantic versioning and release a major version and be okay?

[rlespinasse]

I see this change as a new feature, not a breaking change.
That also why the _SLUG_URL is not impacted by this change.
This will act as minor version on semantic versioning level.

[rlespinasse]

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀