Coder Social home page Coder Social logo

Comments (3)

rlespinasse avatar rlespinasse commented on July 17, 2024 1

This bug occurs when this action is used before or without actions/checkout@v3

  1. GITHUB_SHA_SHORT is filled
    - uses: actions/checkout@v3
    - uses: rlespinasse/github-slug-action@v4
  2. GITHUB_SHA_SHORT isn't filled
    - uses: rlespinasse/github-slug-action@v4
    - uses: actions/checkout@v3
  3. GITHUB_SHA_SHORT isn't filled
    - uses: rlespinasse/github-slug-action@v4

rlespinasse/github-slug-action@v3 is not impacted because the v3 version does not checkout reference (and so does not need a git repository).

Two possibilities to fix that

  • 1️⃣ Document it as a feature, but this will make actions/checkout action mandatory for rlespinasse/github-slug-action@v4 (and this can be explained as one of the breaking changes of the v4 branch)
  • 2️⃣ Make the rlespinasse/shortify-git-revision action support the shortify of the git revision even in case of a missing git repository (and document this behavior in both actions)

from github-slug-action.

rlespinasse avatar rlespinasse commented on July 17, 2024 1

We will go with the solution 2️⃣

from github-slug-action.

github-actions avatar github-actions commented on July 17, 2024

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from github-slug-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.