Comments (7)
I will fix it to keep pull-<pr number>-merge
part and document it.
In addition, @Fryuni Can you tell me more about your use case? maybe we need to do more.
from github-slug-action.
We use the slug as a revision tag on Google Cloud Run to get a url for the PR. It has a character limit that is too low for us to use the branch name, but using the ref slug works fine.
from github-slug-action.
Thanks for the explanation,
I will finally revert the breaking change, open a bug (which I have forget to do 😄 the first time) and take time to find a proper solution.
from github-slug-action.
I think the behavior you changed to is the correct one. I was using something that was technically unintentional. Solved it easily by prefixing pr-
to the tag.
I would just document the change on the release notes
from github-slug-action.
@Fryuni will do
from github-slug-action.
In addition to the related PR, the release notes have been updated https://github.com/rlespinasse/github-slug-action/releases/tag/3.3.0
from github-slug-action.
🎉 This issue has been resolved in version 3.4.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from github-slug-action.
Related Issues (20)
- Feature: domain name compatible slug (no underscores) HOT 4
- GitHub define GITHUB_REF_NAME as default environment variable HOT 7
- Rework the documentation HOT 1
- Bug: `SLUG_URL` can end with a hyphen HOT 8
- The automated release is failing 🚨
- Change Tagging To `vX.Y.Z` HOT 7
- GitHub Actions: Deprecating save-state and set-output commands HOT 2
- Error on GitHub Enterprise Server 3.6.2 since [email protected] HOT 6
- Prepare the ownership change of this action HOT 1
- github.token is read-only on new repositories HOT 1
- Use actionlint on this repository HOT 1
- Reporting a vulnerability HOT 2
- GitHub Actions: Transitioning from Node 16 to Node 20 HOT 3
- End of life of v3 HOT 2
- Watch other actions releases and propose a PR with the updated versions HOT 1
- Feature wish: option to set a different slug length than 63 HOT 3
- GITHUB_SHA_SHORT Not Working in V4 HOT 3
- GITHUB_SHA_SHORT returning variable length HOT 6
- multiple - character are removed HOT 2
- Error: The input 'lenght' is mandatory with 'short-on-error' set to 'true' in v4.2.0 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-slug-action.