Coder Social home page Coder Social logo

Comments (7)

rlespinasse avatar rlespinasse commented on July 17, 2024

I will fix it to keep pull-<pr number>-merge part and document it.

In addition, @Fryuni Can you tell me more about your use case? maybe we need to do more.

from github-slug-action.

Fryuni avatar Fryuni commented on July 17, 2024

We use the slug as a revision tag on Google Cloud Run to get a url for the PR. It has a character limit that is too low for us to use the branch name, but using the ref slug works fine.

from github-slug-action.

rlespinasse avatar rlespinasse commented on July 17, 2024

Thanks for the explanation,
I will finally revert the breaking change, open a bug (which I have forget to do 😄 the first time) and take time to find a proper solution.

from github-slug-action.

Fryuni avatar Fryuni commented on July 17, 2024

I think the behavior you changed to is the correct one. I was using something that was technically unintentional. Solved it easily by prefixing pr- to the tag.

I would just document the change on the release notes

from github-slug-action.

rlespinasse avatar rlespinasse commented on July 17, 2024

@Fryuni will do

from github-slug-action.

rlespinasse avatar rlespinasse commented on July 17, 2024

In addition to the related PR, the release notes have been updated https://github.com/rlespinasse/github-slug-action/releases/tag/3.3.0

from github-slug-action.

rlespinasse avatar rlespinasse commented on July 17, 2024

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from github-slug-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.