rkallos / erl-filewatch Goto Github PK

As per this comment, the EUnit tests should be improved so that they are easier to debug.

Currently the filewatch driver sends all events back to Erlang, where they are deduplicated by filewatch.erl before being sent onward.

I think a good way of handling this is to create a bitfield with length equal to the number of files being watched and flip a bit for a file if an inotify event has been received for that file.

Right now filewatch cannot watch very many files. There are several barriers to take down before the driver can really scale feasibly. The main goal is to be able to handle at least 64k files. The first step to this is likely to implement deduplication in C, as per this issue.

Problematic line: https://github.com/rkallos/erl-filewatch/blob/master/src/filewatch.erl#L99

The logic here is that if there are two watch pairs for the same file, only the term from the second watch pair will be sent in a message from filewatch.