rjbs / log-dispatchouli Goto Github PK

Version 2.007 fails here with the following message:

#   Failed test 'logged timestamp, pid, and hash'
#   at t/file.t line 30.
#                   'Thu Sep 26 07:42:24 2013 [4383] point: {{{"x": 1,"y": 2}}}
# '
#     doesn't match '(?^:^.+? \[4383\] point: \{\{\{("[xy]": [12](, )?){2}\}\}\}$)'
# Looks like you failed 1 test of 4.
t/file.t ...................... 
Dubious, test returned 1 (wstat 256, 0x100)

jquelin wants to be able to set log_pid at times later than logger instantiation.

This was originally https://rt.cpan.org/Ticket/Display.html?id=67218

This is a follow-up to RT#77622. The issue there is that $log->log_debug('message') and $log->log({level => 'debug'}, 'message') are not equivalent. The first is suppressed by the debug flag, and the second is not.

You stated that you are satisfied with that behavior, and I'm ok with that. I have to agree that a careful reading of the documentation does support the position that the debug flag is only relevant to log_debug, not log.

But you shouldn't need to read the docs that closely. The documentation for log should clearly state that it logs all messages regardless of level, and does not consult the debug flag.

On a side note, the Proxy docs have a bug: it says "(bug to the 'debug' logging level)" when you meant "but" (or possibly just delete that word altogether).

$logger->proxy({ prefix => "foo" }); is a typo I could see myself making.

This method (any others with args?) should be strict perhaps?

If neither JSON::XS nor Cpanel::JSON::XS are available for JSON::MaybeXS some test fail:

t/events.t ............. 1/? 
    #   Failed test 'refref becomes JSON flogged'
    #   at t/events.t line 360.
    # Compared $data->[0]
    #    got : 'event=json-demo foo.a=1 bar="{{{\"a\": 1}}}" baz={{[12,34]}}'
    # expect : 'event=json-demo foo.a=1 bar="{{{\"a\": 1}}}" baz="{{[12, 34]}}"'
    # GOT: event=json-demo foo.a=1 bar="{{{\"a\": 1}}}" baz={{[12,34]}}

    #   Failed test 'parsing gets us JSON string out, because it is just strings'
    #   at t/events.t line 370.
    # Compared $data->[7]
    #    got : '{{[12,34]}}'
    # expect : '{{[12, 34]}}'
    # Looks like you failed 2 tests of 3.

#   Failed test 'JSON-ification of refrefs'
#   at t/events.t line 389.
# Looks like you failed 1 test of 8.
t/events.t ............. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests

Both the *::XS modules add the expected space.