rizemon / pe Goto Github PK

Input: btw_ex s/10/08/2021 e/23:12/2021

Specifying an invalid date format causes the program to crash with an exception.

Input: add_ex d/ a/456 c/food

The documentation mentioned that description must be non-empty, however specifying an empty description causes the a/ flag and its value to be recognized as both the amount and description.

For the find command, it states that KEYWORD can only be alphanumeric. However, I was able to search using other non-alphanumeric characters, such as -.

Input: add_ex d/some-thing a/1.00 c/Food, find some-thing

Input: add_in d/ a/456 c/Others

Likewise, the DESCRIPTION must be non-empty, but specifying an empty description causes the a/ flag and its value to be recognized as the description.

Despite specifying a valid supported currency: SGD, as mentioned here:

specifying it twice causes it to not recognise the valid currency I specified.

Input: add_ex_d d/KFC a/3 c/Misc D/29-02-2021

The date format stated was DD/MM/YYYY, but putting another type of format causes this exception to occur and the program to crash.

According to the example, it says that the command finds the keyword in the description or categories of expenses/income entries. However, the command also finds the keyword in the amount field as well.

Despite the description and category not containing 69, it still returned my expense that had 69 in its amount.

Input: add_ex d/some-thing a/69.69 c/Food, find 69

For the getCurrency() method, the return type is void, despite being a getter method which is known to return something.

The Features word in blue is did not bring me to the Features section.

Aside from having very small text and making it hard to read, the sequence diagram was broken into 2 pages, thus the readers will have a hard time interpreting it. Perhaps it could be broken down into smaller components and using ref boxes.

Aside from the text being very small and unreadable, there was inclusion of library classes such as Scanner, FileInputStream etc, which could have simply been written as a variable inside of the object entity instead of a seperate entity. Judging from this diagram, it could also suggest that the developers indeed wrote this library classes, which I did not that was the case. Methods of these library classes were also included and were unnecessary.

For the other methods, the return types were mentioned. However for setCurrentTest, the return type was missing.

For the other components, no class diagram or sequence diagrams were specified before the diagrams. However only the Graphing component seem to not follow this standard.

Too many of the details are shoved into the same diagram, resulting it appearing very complex and the wording becoming very small. This will make readers very overwhelmed. Some methods like getter or setters could possibly be ignored since they are trivial, and of course include a note about it.

The given example was add_in_d/december's bonus a/5000 c/salary D/26/12/2021, but it should be:
add_in_d d/december's bonus a/5000 c/salary D/26/12/2021.

Specifying multiple c/ causes it to give me this error instead of simply taking into account only the last occurence as mentioned in features' notes:

Input: find 12/11/2021 1

find 12/11/2021 did return all my expenses on that day, but the above command returned me no results. Users may be confused as to why they were not able to find their correct expenses.

The image states what values CATEGORY can be. However, if I specified an upper case version, it will still accept it, despite not following strictly the given values.

When I tried to type HELP, instead of help, the program does not recognize the command. The user guide did not mention any details about the commands being case-sensitive and users may be confused as to why their commands failed.

For the help command, no parameters were specified but the program reflected to me that the command did not exist. Users may accidentally enter extra parameters and will be confused as to why the command does not exist. Perhaps a more meaning error message could have been provided here?

In the sequence diagram of Loading of Entries from StonksXD_Entries.csv, for the setCurrency() call, it is missing the data type of its parameter.

The return arrow for the self-invocation expenseCategoryToBudget uses a different type of arrow head as compared to the other return arrows. Readers will be confused as they might think a different arrow head may imply a different meaning.

Specifying multiple occurences of the same parameter does not cause it to only take into account the last occurence, depsite being mentioned in the features' notes