Global ID returned in Query vs. ID used in Mutation about graffiti-mongoose

[tothandras]

Hi @vangavroche!
Did you try it? Mutations should handle both global (id) and mongoose (_id) ids.

[vangavroche]

In the example https://github.com/RisingStack/graffiti-mongoose/blob/master/example/user.js where User has friends that are also "User"s

After I created two users (without any friends), the query responses of "users {id, name}" are like

{
  "data": {
    "users": [
      {
        "id": "VXNlcjo1NjY1YWZkMGU1ZWQwMTAzMWU5ODc3MjQ=",
        "name": "Kaka"
      },
      {
        "id": "VXNlcjo1NjY2NWI0M2U1ZWQwMTAzMWU5ODc3MjY=",
        "name": "Messi"
      }
    ]
  }
}

The generated mutation to add user has input that contains

name: String
age: Float
createdAt: Date
friends: [ID]
clientMutationId: String!

When I try to add a user using mutation

mutation M {
  addUser(input: {name:"Ronaldo", age: 12, friends:["VXNlcjo1NjY2NWI0M2U1ZWQwMTAzMWU5ODc3MjY="], clientMutationId:"1234"}) {
    changedUserEdge {
      node {
        name
      }
    }
  }
}

It won't work, since the ID is not a valid one.

[vangavroche]

Do you mean when I query the ID to set such association ("friends" in this case), I should explicitly get the _id to use?

Using query like this:

query U {
  users {
    _id, name
  }
}

[vangavroche]

BTW, is there any special reason why the singular object reference is not supported in the mutation field generation?

https://github.com/RisingStack/graffiti-mongoose/blob/master/src/schema/schema.js#L124

In the case like

//
const TodoSchema = new mongoose.Schema({
  text: {
    type: String
  },
  createdAt: {
    type: Date,
    default: Date.now()
  },
  completed: {
    type: Boolean,
    default: false
  },
  owner: {
    type: mongoose.Schema.Types.ObjectId,
    ref: 'User'
  }
});

owner field is not used as the mutation input.

To me it seems an easy problem to solve

else {
        // In this case it is assume that the field is a singular object reference like
        // {
        //    type: ObjectId,
        //    ref: "User"
        // }
        //
        inputFields[field.name] = {
          name: field.name,
          type: _graphql.GraphQLID
        };
      }

But I wonder if there's anything I'm missing.

[tothandras]

@vangavroche Okay, the add mutation error is a real bug, see #71 for a quick fix.
I am looking into the object input now.

[tothandras]

@vangavroche I've added the reference support too to the PR, although we might need more testing.

[vangavroche]

@tothandras thanks.

[tothandras]

@vangavroche Can you verify that it resolves your issues? :) I could have missed something. Please add a thumbs up to the PR, I will merge it then.

[vangavroche]

Yes, it works and solves the issue.

[tothandras]

Released under v4.3.2.