Comments (4)
Upon closer inspection, i have figured this out. However the README should be updated as the request
parameter is undefined
, while the root
parameter actually contains the request.
const schema = getSchema([User], { hooks: {
singular: {
pre: (next, root, args, request)=> {
console.log(root.request.user); // => { email: '[email protected]' }
console.log(request); // => undefined
next();
},
post: (next, value)=> {
//...
next();
}
}
}});
Perhaps the shifted signature of [email protected] has something to do with it. Here's the signature at 0.6.2:
graphql(schema, requestString, rootValue, contextValue, variableValues, operationName) {
And here's what graffiti passes:
return graphql(schema, query, { request }, context, parsedVariables)...
at L41
from graffiti-mongoose.
@cellis for mutation
is even more weird
doc
mutation: {
pre: (next, args, context) => next(),
post: (next, value, args, context) => next()
}
actually
mutation: {
pre: (next, args, context, what) => {
console.log(what.rootValue.request.user);
next();
},
post: (next, value, args, context) => {
next();
}
}
And context
is empty {}
from graffiti-mongoose.
@tothandras I'm not sure PR for read me is enough, something really wrong there
Here's workaround for me atm
const hooks = {
viewer: {
pre: (next, args, foo, context, options) => {
console.log(options.rootValue.request.user);
next()
},
post: (next, value) => {
next()
}
},
singular: {
pre: (next, root, args, request, options) => {
console.log(options.rootValue.request.user);
next();
},
post: (next, value, args, context) => {
next();
}
},
plural: {
pre: (next, root, args, request, options) => {
console.log(options.rootValue.request.user);
next();
},
post: (next, value, args, context) => {
next();
}
},
mutation: {
pre: (next, args, context, options) => {
console.log(options.rootValue.request.user);
next();
},
post: (next, value, args, context) => {
next();
}
}
}
module.exports = hooks
Somehow nested viewer change an order of arguments, and here's a problem
plural: {
pre: (next, root, args, request, options) => {
// Normal plural query will return `root.request.user` properly
// But mutation with viewer plural will return `{_type: "Viewer", id: "viewer"}`
// and `root.request` will be `undefined`
console.log(root.request.user);
// Working both query, mutation
console.log(options.rootValue.request.user);
next();
}
Took me a day to figure this out 🤕
from graffiti-mongoose.
Thanks for finding this! PR's are welcomed if you have time to fix it @cellis, @katopz!
from graffiti-mongoose.
Related Issues (20)
- Implicit dependency on babel-polyfill HOT 9
- Cannot set currently-valued fields to null in update mutation HOT 2
- How to make a custom field: id? HOT 10
- "TypeError: Cannot read property 'forEach' of undefined" when embedded object field is a reference HOT 6
- Custom query thunk - accepts only InputObject types HOT 3
- Question on customQueries HOT 7
- Example project doesnt work with [email protected] and [email protected] HOT 1
- Async hook support HOT 2
- Get specific field validation error?
- How to mutate nested Schema? HOT 3
- What is different between id and _id HOT 1
- UNMET PEER DEPENDENCY HOT 1
- Maintainer Volunteer Thread HOT 1
- Mongoose ObjectId and GraphQL id is not the same. How to link them? HOT 5
- It is possible to add some description to schema and to be reflected in the docs?
- Does graffiti-mongoose works with react-apollo ? HOT 2
- Custom mutations?
- Custom queries/mutations HOT 1
- setTypeFields bug
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graffiti-mongoose.