riser101 / setup-nginx-wordpress Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 140 KB

wordpress-nginx script

Python 100.00%

setup-nginx-wordpress's People

Contributors

Watchers

setup-nginx-wordpress's Issues

Why Hardcode password?

Hi,
Why you hardcoded MySQL password

 conn=pymysql.connect(user='root',passwd='m')

Its security loop hole in your script. You must generated random password during run time or let users decide which password to use.

Script must install required modules first

Hello,
While running your script, we are getting import errors.
You must create install script, which will install all dependencies first.

root@vagrant-ubuntu-trusty-64:~# python3 rtcamp-assign.py php
Traceback (most recent call last):
  File "rtcamp-assign.py", line 4, in <module>
    import pymysql
ImportError: No module named 'pymysql'

Used non pythonic way

Hi,
You used most of shell commands in your script. Such as following part of your code:

os.system('ln -s /etc/nginx/sites-available/'+domainName+' /etc/nginx/sites-enabled/')
os.system('mkdir -p /var/www/'+domainName+'/htdocs/ /var/www/'+domainName+'/logs/ && cd /var/www/'+domainName+'/htdocs/')
os.system('wget http://wordpress.org/latest.tar.gz')
os.system('tar --strip-components=1 -xvf latest.tar.gz && rm latest.tar.gz')
os.system('chown -R www-data:www-data /var/www/'+domainName+'/ ')

instead of os.system("shell command") you must use python functions to all this.

Recommend Projects