Coder Social home page Coder Social logo

riot-redline-plugin's People

Contributors

kallan357 avatar torstens73 avatar

Stargazers

avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

kallan357 sdorra gses autotraderuk torstens73 lawfulevilorg isabella232

riot-redline-plugin's Issues

Expose or document filemode setting from redline

I have a script which is executable in my git repo, and during the build, but ends up not executable on the target system. I'd like to specify the mode of this file, presumably within the mapping?

Adding the ability to set file permissions when building RPM

Currently it is not possible to set file permissions on the files that are installed by an RPM built with riot-redline-plugin.

Before we are able to implement this change, redline must be updated. The changes have been made and a pull request reated for version 1.1.17, but this has not yet been released. When this is done we can create a pull request and add the new functionality.

Expose setting RPM file and directory directives from Redline

In an RPM file, some files which are contained may be tagged as %config or %noreplace.

These options are important when updating (as well as uninstalling) RPMs. Especially if you install an updated version of an RPM onto a machine where an earlier version has already been installed you want to be sure you don't overwrite any configuraion files which come with the RPM package for initial installation but may have been changed by the administrator or user since installation.

There are some more directives, check http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html for details.

Document and/or expose links, and dependencies

I'd like to do two things:

  1. Declare that my RPM depends on the RPM equivalent of debian "java6-runtime"
  2. Create a symlink on the target system

These seem to be available in redline, but it's not obvious how to use them and they don't appear to be documented. Excuse me if I'm suffering domestic blindness again.

Tree structure is flattened when mapping a directory

Suppose you're using in your POM something like:

<mapping>
    <directory>/usr/share/whatever</directory>
        <sources>
            <source>${project.basedir}/whatever</source>
        </sources>
</mapping>

In case there is a structure like

whatever/fileA
whatever/foo/fileB
whatever/foo/deeper/fileC

it will get mapped to

whatever/fileA
whatever/foo/fileB
whatever/foo/fileC

i.e. any tree like structure will be flattened to only one level deep.

Groovy Build Error

I had a quick look, but couldn't make sense of this at all. Any clues from anyone?

[ERROR] Failed to execute goal org.codehaus.gmaven:gmaven-plugin:1.3:compile (default) on project riot-redline-plugin: startup failed, /home/fred/repos/java/riot-redline-plugin/src/main/groovy/com/riotgames/maven/redline/RedlineMojo.groovy: -1: The return type of org.redline_rpm.payload.Directive getDirective() in com.riotgames.maven.redline.RedlineMojo$_parseMapping_closure4_closure6 is incompatible with int getDirective() in groovy.lang.Closure.
[ERROR] Node: org.codehaus.groovy.ast.MethodNode. At [-1:-1]  @ line -1, column -1.

NPE with missing configuration/packaging/release parameter

It should complain and fail gracefully. I didn't try others, but I presume others are also not null checked?

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.riotgames.maven:riot-redline-plugin:1.2.0-SNAPSHOT:rpm (default) on project OpenLogViewer: Execution default of goal com.riotgames.maven:riot-redline-plugin:1.2.0-SNAPSHOT:rpm failed.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default of goal com.riotgames.maven:riot-redline-plugin:1.2.0-SNAPSHOT:rpm failed.
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
    ... 19 more
Caused by: java.lang.NullPointerException
    at org.freecompany.redline.header.AbstractHeader.createEntry(AbstractHeader.java:202)
    at org.freecompany.redline.Builder.setPackage(Builder.java:141)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)
    at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)
    at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1047)
    at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:877)
    at org.codehaus.groovy.runtime.InvokerHelper.invokePojoMethod(InvokerHelper.java:781)
    at org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:772)
    at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodN(ScriptBytecodeAdapter.java:164)
    at com.riotgames.maven.redline.RedlineMojo.execute(RedlineMojo.groovy:137)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
    ... 20 more

Expose RPM signing functionality of Redline library

The Redline library provides the capability to sign RPM files, which is a requirement to get them uploaded to many repositories.

I am thinking of adding that capability to the riot-redline-plugin, introducing an extension to the plugin configuration like this:

<configuration>
  [...]
  <signature>
    <keyring>secring.gpg</keyring>
    <privateKeyId>foo</privateKeyId>
    <privateKeyPassphrase>redline</privateKeyPassphrase>
  </signature>
  [...]
</configuration>

It would be a bit cleaner actually to do it this way:

<configuration>
  [...]
  <signature>
    <keyring privateKeyId="foo" privateKeyPassphrase="bar">secring.gpg</keyring>
  </signature>
  [...]
</configuration>

Just it would breach with the "way of doing things" in the rest of the plugin, so I'd do the first option.

Comments please ...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.