ridedott / eslint-config

A safety-oriented, fp-first configuration of ESLint.

eslint-config

Safety-oriented, fp-first configuration of ESLint.

Usage

Basic setup

To use this configuration, install it as a devDependency first, alongside ESLint itself:

npm install --save-dev @ridedott/eslint-config eslint

Once it is finished, add an ESLint configuration to your project in a top-level .eslintrc.yaml file. An example configuration:

env:
  es6: true
  node: true
extends: '@ridedott/eslint-config'
overrides:
  - env:
      jest: true
    files:
      - __mocks__/**/*.ts
      - src/**/*.spec.ts
      - test/**/*.ts
    rules:
      '@typescript-eslint/no-magic-numbers': off
      max-lines-per-function: off
      max-statements: off
      no-magic-numbers: off
      unicorn/no-unsafe-regex: off
  - files:
      - scripts/**/*.ts
    rules:
      no-console: off
  - files:
      - __mocks__/**/*.ts
    rules:
      unicorn/filename-case: off
parserOptions:
  ecmaVersion: 2020
  project: tsconfig.json
  sourceType: module

and a script in your package.json which will help you run ESLint with correct dependencies:

{
  "scripts": {
    "lint": "eslint '**/*.ts'",
    "lint:fix": "eslint --fix '**/*.ts'"
  }
}

Visual Studio Code integration

If you would like to add a Visual Studio Code integration too, consider starting with the following configuration.

Add an extension to the list of suggested ones in .vscode/extensions.json:

{
  "recommendations": ["dbaeumer.vscode-eslint"]
}

Add ESLint settings to the workspace settings in .vscode/settings.json:

{
  "eslint.codeAction.disableRuleComment": {
    "enable": true,
    "location": "separateLine"
  },
  "eslint.codeAction.showDocumentation": {
    "enable": true
  },
  "eslint.enable": true,
  "eslint.lintTask.enable": true,
  "eslint.run": "onType"
}

Getting Started

These instructions will get you a copy of the project up and running on your local machine for development and testing purposes. See usage notes on how to consume this package in your project.

Prerequisites

Minimal requirements to set up the project:

• Node.js v10, installation instructions can be found on the official website, a recommended installation option is to use Node Version Manager. It can be installed in a few commands.
• A package manager like Yarn or npm. All instructions in the documentation will follow the npm syntax.
• Optionally a Git client.

Installing

Start by cloning the repository:

git clone [email protected]:ridedott/eslint-config.git

In case you don't have a git client, you can get the latest version directly by using this link and extracting the downloaded archive.

Go the the right directory and install dependencies:

cd eslint-config
npm install
npx husky install

That's it! You can now go to the next step.

Tests

This repository does not contain any source code, just the configuration, so no tests are present.

Formatting

This project uses Prettier to automate formatting. All supported files are being reformatted in a precommit hook. You can also use one of the two scripts to validate and optionally fix all of the files:

npm run format
npm run format:fix

Publishing

Publishing is handled in an automated way and must not be performed manually.

Each commit to the master branch is automatically deployed to both npm and GitHub Packages registries with a version specified in package.json. All other commits are published as pre-releases by the integration pipeline.

Contributing

See CONTRIBUTING.md.

Built with

Automation

• GitHub Actions

Versioning

This project adheres to Semantic Versioning v2.

IMPORTANT Changes and additions of linting rules are not considered breaking changes.

eslint-config's Issues

False positive from @typescript-eslint/no-unnecessary-condition

Linting the example code below I am presented with the following error:

Unnecessary conditional, value is always falsy. @typescript-eslint/no-unnecessary-condition

const list1: string[] | undefined;

const list2 = ['bar', 'baz'].some(
  (value: string): boolean => list1?.includes(value) ?? false,
);

As list1 is potentially undefined the nullish coalescing (??) makes sense. A potential workaround is to instead write:

const list2 = ['bar', 'baz'].some(
  (value: string): boolean => list1?.includes(value) === true,
);

Though I feel like this should not be reported by the linter as an error.

Dependabot couldn't authenticate with npm.pkg.github.com/ridedott

Dependabot couldn't authenticate with npm.pkg.github.com/ridedott.

Dependabot tried to authenticate with the details you previously provided, but authentication failed. If they are no longer valid you will need to provide Dependabot with new credentials.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Dependabot couldn't authenticate with npm.pkg.github.com/ridedott

Dependabot couldn't authenticate with npm.pkg.github.com/ridedott.

Dependabot tried to authenticate with the details you previously provided, but authentication failed. If they are no longer valid you will need to provide Dependabot with new credentials.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Invalid config for rule @typescript-eslint/array-type

Hi! , thanks for this super interesting ESLint configuration ;)

Trying to use in my projects gives me the error "Configuration for rule @typescript-eslint/array-type is invalid: Value array-simple should be object."

Taking a look to the code, rules/typescript.js:3 seems to be the problem, the documentation says that it expects an object but it's receiving a string.

Dependabot couldn't authenticate with npm.pkg.github.com/ridedott

Dependabot couldn't authenticate with npm.pkg.github.com/ridedott.

Dependabot tried to authenticate with the details you previously provided, but authentication failed. If they are no longer valid you will need to provide Dependabot with new credentials.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.