Comments (4)
It is just that you're trying to abstract something that no one is going to need.
Over engineering I say! 💃
When people use Ash, if they want to extend the EntityStateMachine they will simply just do that, but no one is gonna re-use/implement an IState from the Ash framework as part of their domain logic.
Anyone who would use an IState kinda thing, would very likely roll out their own in a sub-layer underneath the Entity context, with a state machine that fits their needs better.
The contract of both EntityStateMachine and EngineStateMachine works very well for those specific concepts, but for me it does not do the job for other state based parts within the game.
from ash.
That is true however just because they look similar no need to assume it needs to be refactored into a general form.
Looking closely it is clear that the changeState() is by far the bulk of each class, and thus refactoring is really pointless as it's not catering for what matters.
If anything they could potentially share an IAshStateMachine interface or something, but I don't think it will benefit...
from ash.
@guerrillacontra Thank you!
And I just can't agree with you. EntityStateMachine and EngineStateMachine, in a high level of view, they does the same thing: StateMachine. The are different is just because they depends on different states. EntityState
and EngineState
have different interface.
I think we don't need to have IAshStateMachine
but IState
. (Find What Is Varying and Encapsulate It)
from ash.
@guerrillacontra But true, indeed. The duplicated code in the two StateMachine is trivial.
from ash.
Related Issues (20)
- Should we enable developers to extend Ash to use more sophisticated rules for adding entities to node lists? HOT 14
- System.priority can be Number HOT 2
- Add ability to get all componentes on an Entity HOT 3
- systems communication HOT 2
- Scripting solutions with ASH. HOT 1
- Entity.clone() - possible error if component registered with BaseClass HOT 1
- entity.asNode(); HOT 1
- User input events queue HOT 6
- Robotlegs Ash Extension fails with latest robotlegs HOT 1
- NodeList.forEach
- ComponentMatchingFamily.componentAddedToEntity check added component HOT 1
- Avoid Vector/Array push() method HOT 4
- Please start adding version tags HOT 5
- SignalBase.removeAll()
- Test file names does not match the class name been tested.
- EngineStateMachine changing states during Engine update HOT 1
- Removing entity that was removed before causes entity list change. HOT 2
- ASDoc
- Clear Next/Previous when removing Entity from EntityList HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ash.