richard4339 / destiny2-php Goto Github PK

Hello,

I was wanting to provision this on a server, but I'm a little confused on how to get it going. I'm running PHP7 on my server, and have ran the composer command:

$ composer require richard4339/destiny2-php
Using version ^0.2.4 for richard4339/destiny2-php
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 5 installs, 0 updates, 0 removals
  - Installing guzzlehttp/promises (v1.3.1): Downloading (100%)         
  - Installing psr/http-message (1.0.1): Downloading (100%)         
  - Installing guzzlehttp/psr7 (1.4.2): Downloading (100%)         
  - Installing guzzlehttp/guzzle (6.3.3): Downloading (100%)         
  - Installing richard4339/destiny2-php (v0.2.4): Downloading (100%)         
guzzlehttp/guzzle suggests installing psr/log (Required for using the Log middleware)
Writing lock file
Generating autoload files

After this part, I'm not sure what I need to do. It seems to have only created a vendor directory on the server. Do you mind elaborating a bit on how to get this up and going? I'm essentially just wanting to create a simple website/app with Xur information (location/stock). Thanks!

The rescind invite method appears to not be working

I set the internalRequest method to not re-instantiate httpClient if it already existed. I added this because when running commands back to back you can hit the recursion limit in xdebug easily due to it stacking all of the plugins for every call. However, doing so breaks our tests. How should this be handled?

The $body argument in internalRequest should be handled better.

Currently, it is performing a json_encode if the argument is of the type array. If you want to hand it form data as would be required for an oauth request it has to encoded beforehand.

http_build_query(
    ['example' => 'form data']
    , '', '&')

You can't test the $body argument at the last minute because both the json encoded string and the string above are both strings.

This could simply be written to work like Guzzle where the body for a form should be wrapped in the array form_params. At that point, would it be better to potentially have json encoded body to be wrapped in the an array with key json (again mimicking Guzzle), as seen below?

[
    'json' =>
        [
            'message' => ''
        ]
]);