jbrains-pos's People
jbrains-pos's Issues
An example of a "structural name"
This is not necessarily a problem, but this function name looks like a "structural name" to me. (See http://blog.thecodewhisperer.com/permalink/a-model-for-improving-names for more information.) What might happen if you tried to improve this name?
Function `receivedPrice` stores something that I don't consider a "price"
What name would better describe what this function does?
Using a function expectation when a stub would suffice?
I don't know the syntax very well, but it looks like this line of code checks the parameter in the query. Do you really need to do that here? What if you write a test that checks only one bit of behavior instead of two? (And if I have the syntax wrong, then disregard this issue.)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.