rhinstaller / anabot Goto Github PK

The current handler for storage error dialog (displayed on the Welcome screen e. g. when two volume groups with identical names are found) doesn't work with current (RHEL-8+) dialog.

The text it looks for has changed, plus the reason of failure is not present in the heading, but in the error description.

What has to be done:

• Update the text in the heading of the dialg Anabot is looking for, don't use string formatting for RHEL-8+ to substitute the particular error as it's not present in the text anymore.
• Fix how the exact error (e. g. multiple LVM volume groups with the same name) is be checked, look for the text at the beginning of the error message text in the lower part of the dialog.

There is no check function for /installation/hub/create_user/advanced/groups and thus the check fails.

Consider the following recipe:

<ez:installation xmlns:ez="http://fedoraproject.org/anaconda/anabot/recipe/tiny/1">
  <ez:hub>
    <partitioning>
      <disk name="*" action="select" />
      <mode mode="manual" />
      <done />
      <advanced>
        <autopart />
        <select mountpoint="Foo" required="yes" />
        <done />
        <summary />
      </advanced>
    </partitioning>
  </ez:hub>
</ez:installation>

I would expect the recipe to fail as <autopart /> does not create any mountpoint named "Foo" so it cannot be selected. However, Anabot silently ignores the fact the mountpoint does not exists and continues the installation. The same behavior occures after using <add> element.

When there is no <autopart /> or <add> element prior to the <select ...>, Anabot reports failure, exactly as expected.

I'm using latest Anabot from the main branch (commit d1077a3)