Comments (3)
When the request comes with an unknown user-agent it returns 'phone' because there's an higher chance that it comes from a mobile device than from a desktop device (new phone OSes and devices appear on a monthly basis).
When there's no user-agent it returns 'desktop' because I'm assuming that it's an unusual situation (tests?) or some sort of an unknown device type. The best behavior (IMO) is to show as if I'm on a desktop.
But I like your suggestion on creating a config option. This way I'll add two: one to return when get an unknown user-agent and other for the default device (to be returned when there isn't an user-agent).
What do you think?
from express-device.
I like the way that I can set my own device types for both situations now.
But may I suggest you name the options more self-explanatory like this:
unknownUserAgentDeviceType
emptyUserAgentDeviceType
I find your current option names conflictive with your code. If your parser does not match a known agent I would expect it to return the default device type. But your defaultDeviceType
would be returned when the user-agent is empty, which is more unlikely than an unknown agent.
from express-device.
done!
from express-device.
Related Issues (20)
- What new features should I include for version 0.4? HOT 6
- Would it be possible to add support for hbbtv in the user-agent string
- Docs incorrect HOT 1
- Support car device type HOT 1
- Detect chromecast as TV HOT 1
- Detect Playstation 4 as TV HOT 1
- Feature request - refactor UA parsing to separate module HOT 18
- Support default convention for express middleware
- FTLOG please added example of in-Express use HOT 2
- Googlebot on smartphone classified as "phone" instead of "bot" HOT 3
- wget shows up as a phone HOT 3
- README a bit confusing (parseUserAgent default) HOT 5
- is_desktop is not defined :( HOT 3
- ipad pro 12.9 inch returns device.type as phone HOT 2
- Make isBot orthogonal? HOT 2
- code markup with Native Node.js HOT 1
- [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
- Typescript support HOT 1
- Request using Postman detects as "phone"
- Request with iPad Safari is detected as desktop
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-device.