Coder Social home page Coder Social logo

Comments (8)

rgthree avatar rgthree commented on August 14, 2024

When you load an image's workflow with the Seed node, you're right that the Last Queued Seed button is grayed out; however, the seed input itself will be pre-filled with that images' seed.

So, in this screenshot I just dragged a generated image into comfy to load the workflow and, even though the seed was generated with "-1" the Seed node pre-fills the actual seed of the image. So it should be ready to go.
seed

Are you experiencing something different?

from rgthree-comfy.

diaopal avatar diaopal commented on August 14, 2024

@rgthree

It's -1 for me.

out.mp4

from rgthree-comfy.

rgthree avatar rgthree commented on August 14, 2024

Weird. I’ll check it out!

Which browser do you use?

EDIT: Looks like it's MS Edge from that downloads menu, though maybe I'm wrong. Unfortunately, I've tried on Firefox, Brave, and MS Edge and it seems to be working correctly everywhere. The following video is what I expect.

seed_edge.mp4

If you're still experiencing it, can you open the browser DevTools (usually "F12" key) and see if you get any errors in the DevTool Console?

Secondly, here's the png I just generated in the video. What happens when you download this and drop it into ComfyUI? Do you get the correct seed value then?
ComfyUI_temp_qpmzj_00003_ (1)

from rgthree-comfy.

diaopal avatar diaopal commented on August 14, 2024

I found the culprit. It is because of ComfyUI_NestedNodeBuilder. It seems like something in NNB is preventing the seed from being serialized properly because I can load workflows working as intended from a machine that has NNB disabled while I have NNB enabled on my main machine.

Secondly, here's the png I just generated in the video. What happens when you download this and drop it into ComfyUI? Do you get the correct seed value then?

Yes, I get the correct seed value in that image.

from rgthree-comfy.

rgthree avatar rgthree commented on August 14, 2024

Yea, looks like ComfyUI_NestedNodeBuilder overwrites the serializeValue method for widgets which the Seed node here needs to own its serialization (since it needs to switch out the "-1" for the actual seed when it gets serialized).

You'll have to file a bug with that project; not sure why it stops serialization... looks like it may just be copy+paste from the original ComfyUI codebase.

from rgthree-comfy.

cliffrowley avatar cliffrowley commented on August 14, 2024

FYI I am seeing this issue now, and I don't have NestedNodeBuilder installed. I extracted the data from a PNG to check that the seed is actually present, and yes, it's there, but when I load the image into ComfyUI the RG Seed node says -1.

FWIW I have tried with Safari, Chrome and Brave, and I see the same thing in all browsers.

from rgthree-comfy.

rgthree avatar rgthree commented on August 14, 2024

Can you provide a workflow to help debug? @cliffrowley

from rgthree-comfy.

rgthree avatar rgthree commented on August 14, 2024

This actually looks like a new breaking change upstream from comfy. See #69 for a solution until it can be fixed.

from rgthree-comfy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.