Coder Social home page Coder Social logo

Comments (7)

davidchenhs avatar davidchenhs commented on August 14, 2024

for mute button and bypass button

from rgthree-comfy.

52Hz-p avatar 52Hz-p commented on August 14, 2024

是的,非常需要此功能,我查看了其他的组开关,都不能,不知道是否是对于组的开关无法控制,我查看了普通布尔节点和组开关他们的类型都是布尔,但是不知道为啥不可以转换成输入

from rgthree-comfy.

rgthree avatar rgthree commented on August 14, 2024

This comes up a lot but, unfortunately, it's not really possible to toggle mute/bypass with an input as they are in two completely different phases of execution.

Muting, Bypassing, and other actions are all modifying the active workflow in the browser in real-time. Whether you use ctl+M, or a Fast Muter, etc. when you do so, it's changing those nodes' status right there in the browser workflow--there's no communication with the server.

An input, however, is evaluated while the server is executing and, at that point it is infeasible to mute/bypass a node or group based on the value of that input mid-execution as we're no longer in the browser to manipulate the workflow that would have been sent to the server. (At least not without an extensive re-write to ComfyUI's execution and APIs.)

from rgthree-comfy.

DrJKL avatar DrJKL commented on August 14, 2024

At least not without an extensive re-write to ComfyUI's execution

from rgthree-comfy.

rgthree avatar rgthree commented on August 14, 2024

Yea, this is a promising change, but it’s still not gonna be enough.

The API format doesn’t know about “groups” nor even the position of the items in the workflow. I’m also unsure that the API version contains muted nodes at all.

What would need to happen is a rewrite that allows the server to go through the workflow data, calculate the position of the nodes and if they overlap with a group (all without the LiteGraph framework), and then mute the nodes that overlap, etc.

Not impossible, but it’s entirely new, complex work.

from rgthree-comfy.

davidchenhs avatar davidchenhs commented on August 14, 2024

Can we add inversion between repeater and relay?

from rgthree-comfy.

rgthree avatar rgthree commented on August 14, 2024

Can we add inversion between repeater and relay?

Yes, it’s part of the Relay’s properties. You can see more in the docs https://github.com/rgthree/rgthree-comfy?tab=readme-ov-file#mute--bypass-relay

from rgthree-comfy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.