rgrunber / fedoraproject-p2 Goto Github PK

Next version of XMvn is going to change API, so fedoraproject-p2 will need to be updated to keep working.

Failed tests:
ArtifactRepositoryTest.existsFeatureInRepository:98 Artifact Repository must contain an IU referencing an artifact of type org.eclipse.update.feature.
MetadataRepositoryTest.existsFeatureInRepository:107 Metadata Repository must contain an IU referencing an artifact of type org.eclipse.update.feature.
InstallTest.bundleShapeDirUnitInstallTest:84->checkUnitInstallation:110 null

Tests run: 47, Failures: 3, Errors: 0, Skipped: 2

mvn clean verify
[INFO] Scanning for projects...
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project org.fedoraproject.p2:xmvn-p2-installer-plugin:0.0.1-SNAPSHOT (/home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml) has 7 errors
[ERROR] Non-resolvable import POM: Failure to find org.fedoraproject.xmvn:xmvn-parent:pom:2.4.0 in http://mizdebsk.fedorapeople.org/xmvn/repo/ was cached in the local repository, resolution will not be reattempted until the update interval of xmvn has elapsed or updates are forced @ org.fedoraproject.p2:xmvn-p2-installer-plugin:[unknown-version], /home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml, line 32, column 19 -> [Help 2]
[ERROR] 'dependencies.dependency.version' for javax.inject:javax.inject:jar is missing. @ org.fedoraproject.p2:xmvn-p2-installer-plugin:[unknown-version], /home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml, line 47, column 17
[ERROR] 'dependencies.dependency.version' for org.eclipse.sisu:org.eclipse.sisu.inject:jar is missing. @ org.fedoraproject.p2:xmvn-p2-installer-plugin:[unknown-version], /home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml, line 52, column 17
[ERROR] 'dependencies.dependency.version' for org.sonatype.sisu:sisu-guice:jar:no_aop is missing. @ org.fedoraproject.p2:xmvn-p2-installer-plugin:[unknown-version], /home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml, line 56, column 17
[ERROR] 'dependencies.dependency.version' for org.fedoraproject.xmvn:xmvn-install:jar is missing. @ org.fedoraproject.p2:xmvn-p2-installer-plugin:[unknown-version], /home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml, line 66, column 17
[ERROR] 'dependencies.dependency.version' for org.slf4j:slf4j-simple:jar is missing. @ org.fedoraproject.p2:xmvn-p2-installer-plugin:[unknown-version], /home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml, line 70, column 17
[ERROR] 'dependencies.dependency.version' for com.google.guava:guava:jar is missing. @ org.fedoraproject.p2:xmvn-p2-installer-plugin:[unknown-version], /home/akurtakov/git/fedoraproject-p2/xmvn-p2-installer-plugin/pom.xml, line 74, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

I guess a newer version of Tycho is needed:

I get this error when building as part of step 5 in https://github.com/eclipse/orbit/blob/main/Policies.md#milestone-and-recommended-release-process

org.apache.maven.InternalErrorException: Internal error: org.eclipse.tycho.core.ee.UnknownEnvironmentException: Unknown OSGi execution environment: 'JavaSE-17'

FedoraBundleRepositoryTest relies on packaged Eclipse to be installed. When that is not the case, the test fails.
The test should use resources included in git repository and not rely system paths such as /usr/share/java/, /etc/java/eclipse.conf and so on.
Alternatively, the test can use JUnit Assume to skip test execution when packaged Eclipse is not installed.

Recent OSGi specification includes standard API to launch OSGi framework. We should try using it for launching Equinox, instead of currently-used non-standard EclipseStarter.

FrameworkFactory frameworkFactory = ServiceLoader.load(FrameworkFactory.class).iterator().next();

Map<String, String> config = new HashMap<String, String>();
config.put(Constants.FRAMEWORK_STORAGE, "/tmp/some/path");
config.put(Constants.FRAMEWORK_STORAGE_CLEAN, Constants.FRAMEWORK_STORAGE_CLEAN_ONFIRSTINIT);
Framework framework = frameworkFactory.newFramework(config);

framework.start();
BundleContext bundleContext = framework.getBundleContext();