rgleason / dashboard_tactics_pi Goto Github PK

hey folks,

hello from the farthest northern part of Australia! jeeze, first off I just have to say how much I love this plugin. :) I've been using the 'Dashboard' plugin nonstop since converting over 100% to OpenCPN, so that's like... 20,000nm sailed ago or so? thank you so much for picking up where 'Dashboard' left off!

I have a couple of purely cosmetic requests, if you'd be so kind as to entertain them... I am aware that these are incredibly pedantic and absolutely in no way a priority. it has been my intention for a few years now to just submit a pull request, but going through the source I have to admit my coding chops have atrophied, and there are too many other boat projects pulling my attention. maybe the easiest way is just to ask for them here? maybe these are such small edits that they'd literally take someone more familiar with the source code less than a minute to patch? I see nobody has posted here in a while...

anyway. here's my OpenCPN instance, running on a 22" LED monitor in the cabin of my little Islander 34 'X-Wing':

you can see my main Dashboard is pinned to the right side of my screen. my peeves are, in order:

• COG and STW are left-justified, but SOG is left-justified with an extra space added for some reason. can that extra space be removed, or is it there for a reason?

• COG in the image is shown as 192°. down at the bottom of the dashboard, the 'From Ownship' widget shows the cursor being at a bearing of 109 °. why does the 'From Ownship' have a space between the number and the degree symbol? can this space be removed??

• lastly, and I do wonder if this was a design decision, and if so perhaps you could help me understand it... why are the lat/long positions written as "10 35.590 S" instead of "10°35.590'S"??

thanks very much for all your work on this project!

(ps: my kingdom for "fresh water tank level" and "fuel tank level" widgets... the old 'engine dashboard' plugin used to crash OpenCPN on this Linux box, and I don't know where it's gone now...)

This plugin is very similar to Tactics and Dashboard, screenshots to see where DPI awareness would help with the setting of font sizes.

Resize menus width gets stuck and frozen.
Resize menus height is frozen and not possible.
There is a double space in the entries.
Etc..

Currently there is no room to enter values into a number of the parameters.
I would like to know how to fix this. I have tried loading the new version of wxFormbuilder, but it does not accept the dashboard_pi.h file and there is no fdb file in the repository. Furthermore I believe Petri used java or javascript to do the formatin for his later developments. I would like to find a simple way to fix this problem, preferablly by simple edits of the dashboard_pi.h file.

I have carefully checked icons.h and icons.cpp in comparison with weather_routing which works, and Dashboard_tactics conforms to a large degree with weather_routing's icons.

Installation checklist (change to [X] when sure)

I have installed the software for which I am reporting the issues from:

• Your own fork and build Link

• Issue reported in CF DashT thread

Specifications

• OpenCPN Version: 5.8.4
• DashT Version: Latest source code from branch mnt151-frontend2, compiled with the ShipDriver template.
• Operating System :
  • Windows
• Operating System Version : Window 10

Expected Behavior

Mark laylines should appear for the area where the vessel is being sailed

Current Behavior

Mark laylines appear for east longitudes, north latitude. They do not appear for west longitude, north latitude.

Logic is not correct in the code for the intersection of lines.

Possible Solution

Use spherical trig to solve the intersection problem.
Code for solving the problem will be posted here. Unwilling to make a PR as review by Thomas_R and/or Canne is needed.

Steps/Code to Reproduce the Problem

See: https://www.cruisersforum.com/forums/f134/dashboard-tactics-dash-t-226601-16.html#post3862050

I would like to change the existing dashboard colored PIM "listing image" to be a b&w image from Tactics.
How would I do that?

There are some memory images _img in icons.cpp that I believe are used. How would I change these, if this is correct?

I would like to do the same thing in 4 other plugins.

Missing measurement in Kilometers. The settings are set to kilometers for the distance, but the odograph only works in nautical miles.
It's great that there is a convenient odometer functionality in DashT as an alternative to the GPS odometer plugin that is not integrated into the Dashboard.