rgardner / dancingtogether Goto Github PK
View Code? Open in Web Editor NEWListen to music with your friends and family
Home Page: https://www.dancingtogether.live
License: MIT License
Listen to music with your friends and family
Home Page: https://www.dancingtogether.live
License: MIT License
From testing with Nicole, we found that mute is likely good enough. Listeners can always disconnect by closing the browser window. The small mute icon on the tab is also not really discoverable and it's so small it's hard to use for many people.
Font Awesome
<i class="fas fa-volume-off"></i>
<i class="fas fa-volume-up"></i>
likely MIT, but first read through choosealicense.org
New account view in menu bar
Spotify auth tokens are usually valid up to 1 hour. This means that if a user listens to the station long enough, the auth token will expire and Spotify will reject the request and currently, the only work-around is to refresh the page - which, is a minor annoyance :)
Instead, here's the proposed flow:
authentication_error
event. Today, only the music player is subscribed to this event to display a message to the user. Instead, that will be moved to the StationServer class, which will listen for this error and issue a "refresh_access_token" command to the server to get a fresh access token (must be done server-side).Right now, no music starts when a listener joins a station. This is not expected :) When joining a station, the listener should catch up to the current state of the station. e.g. the music picks up at the current position.
ValidationError: ForkTsCheckerWebpackPlugin Invalid Options
options should NOT have additional properties
at Object.validateOptions [as default] (/Users/bobgardner/Developer/dancingtogether/frontend/node_modules/fork-ts-checker-webpack-plugin/node_modules/schema-utils/src/validateOptions.js:32:11)
at new ForkTsCheckerWebpackPlugin (/Users/bobgardner/Developer/dancingtogether/frontend/node_modules/fork-ts-checker-webpack-plugin/lib/ForkTsCheckerWebpackPlugin.js:28:31)
at Object.<anonymous> (/Users/bobgardner/Developer/dancingtogether/frontend/config/webpack.config.dev.js:243:5)
at Module._compile (internal/modules/cjs/loader.js:816:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
at Module.load (internal/modules/cjs/loader.js:685:32)
at Function.Module._load (internal/modules/cjs/loader.js:620:12)
at Module.require (internal/modules/cjs/loader.js:723:19)
at require (internal/modules/cjs/helpers.js:14:16)
at Object.<anonymous> (/Users/bobgardner/Developer/dancingtogether/frontend/scripts/start.js:31:16)
Django channels removed the websocketbridge in a minor release, which has to be replaced with another reconnecting web socket implementation.
This causes an internal server error on station pages because the static file can't be found.
🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨
To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.
Since we didn’t receive a CI status on the greenkeeper/initial
branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.
If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/
.
Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.
dancingtogether/radio/views.py
Lines 129 to 130 in 93e12ff
TODO
comment in 93e12ff. It's been assigned to @rgardner because they committed the code.frontend_ci.yml
lint
test
build_optimized
backend_ci.yml
lint
test
https://auth0.com/blog/how-to-configure-create-react-app/
Being back on the happy path will simplify maintenance.
e.g. users can only refresh their own access tokens, only admins can remove a station, only admins can add new listeners to their station, only DJs can update the playback state
Scenario:
Plan
player_state_change
requestIt was pretty loud when I first connected to a station. It would be nice to persist the setting so the sound isn't so jarring.
This is related to #9, as that allows changing the volume more than just mute/unmute.
I need to root cause this, it could be:
@spotify.fresh_access_token_required
decorator isn't working as expectedIt's related to a javascript error in util.js
, a bootstrap file. TypeError: t is undefined [Learn More]
Controls
e.g. ClientError('bad_spotify_response', 'Spotify servers are experiencing problems')
then surface this on the webpage. Maybe re-use the existing connection status message to say "Spotify is experiencing problems, the stream may not work as expected"
setVolume(0.0) then getVolume() returns null instead of 0.0. Client-side work-around is to treat null as 0.0
I think this was introduced in 9d5b222, as Django's CSRF protection requires the referrer header when HTTPS is used. Here's the Django dev post detailing what this is intended to protect against
The solution here is to turn off the no-referrer header, given its needed for CSRF protection over HTTPS.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.