rgardner / bsh-rs Goto Github PK

cargo run fails with:

   Compiling rustyline v3.0.0
error[E0283]: type annotations needed
   --> /home/gback/.cargo/registry/src/github.com-1ecc6299db9ec823/rustyline-3.0.0/src/lib.rs:655:43
    |
655 |             editor.add_history_entry(line.as_ref());
    |                                      -----^^^^^^--
    |                                      |    |
    |                                      |    cannot infer type for type parameter `T` declared on the trait `AsRef`
    |                                      this method call resolves to `&T`
    |
    = note: cannot satisfy `String: AsRef<_>`
help: use the fully qualified path for the potential candidates
    |
655 |             editor.add_history_entry(<String as AsRef<OsStr>>::as_ref(line));
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
655 |             editor.add_history_entry(<String as AsRef<Path>>::as_ref(line));
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
655 |             editor.add_history_entry(<String as AsRef<[u8]>>::as_ref(line));
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
655 |             editor.add_history_entry(<String as AsRef<str>>::as_ref(line));
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0283]: type annotations needed
   --> /home/gback/.cargo/registry/src/github.com-1ecc6299db9ec823/rustyline-3.0.0/src/history.rs:151:28
    |
151 |             self.add(line?.as_ref()); // TODO truncate to MAX_LINE
    |                      ------^^^^^^--
    |                      |     |
    |                      |     cannot infer type for type parameter `T` declared on the trait `AsRef`
    |                      this method call resolves to `&T`
    |
    = note: cannot satisfy `String: AsRef<_>`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0283`.
error: could not compile `rustyline`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

This issue was generated by todo based on a todo comment in 286f5db. It's been assigned to @rgardner because they committed the code.

First read-through the license to make sure I understand it completely.

• history: prints last commands
• history -c clears the history
• history [n] display last N entries
• help lists all builtins and their signatures
• help [command] outputs help for a specific command
• exit should alert the user if background processes exist and fail to exit
• kill [pid] should a kill process with PID pid

To make it easier to test programs with more complicated arguments, these should be supported:

• quotes (single or double)
• semicolons (for multiple jobs on the same line)

sleep 1 & causes the shell to exit immediately because Readline returns errno 5 (I/O error occurred), I think because stdin is in a bad state. Per bash source, a background command with default stdin should be redirected to /dev/null. But, when I made this change, stdin was still in a bad state - maybe terminal control issues?

Waiting on nix-rust/nix#817 to merge

• research major differences between unix and Windows shells (e.g. job management)
• get MVP working on Windows (e.g. no job management, put nix usage behind #[cfg(unix)])
• add Windows to CI
• get parity between unix and windows
  • get all integration tests passing
  • implement create_pipe in execute_command

• history -s n set size of history buffer
• fg and bg
• printenv and setenv
• properly piping commands
• richer redirection, e.g. python test.py 2>out

wait on Windows support to settle first.

• !n - repeat command numbered n in the list of commands (starting at 1)
• !-n - repeat last nth command (starting at -1)
• !string - searches through history for first item that matches the string (via contains)

Better names

• ParseJob
• ParseCommand

• add examples section
• move features above development

This issue was generated by todo based on a todo comment in 7da52c4 when #31 was merged. cc @rgardner.

I first hit this on Travis when I was using set -e and set +e in the install script. I don't understand why removing those lines fixed the error cargo was returning though.

Now I'm hitting this when experiment with cov:

$ cargo +nightly cov clean && cargo +nightly cov test && cargo +nightly cov report --open
...
running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running debug/deps/integration_tests-40f703f134d886e1

running 7 tests
test test_exit_normal_large_negative ... test test_exit_normal_large_negative has been running for over 60 seconds
test test_command_not_found ... test test_command_not_found has been running for over 60 seconds
test test_simple_redirects ... test test_simple_redirects has been running for over 60 seconds
test test_stderr_redirect ... test test_stderr_redirect has been running for over 60 seconds
test test_simple_pipeline ... test test_simple_pipeline has been running for over 60 seconds
test test_simple_echo ... test test_simple_echo has been running for over 60 seconds
test test_syntax_error ... test test_syntax_error has been running for over 60 seconds



test test_simple_pipeline ... ok
test test_syntax_error ... ok
test test_simple_redirects ... ok
test test_command_not_found ... ok
test test_stderr_redirect ... ok
test test_simple_echo ... ok
test test_exit_normal_large_negative ... ok
...

• tab completion and command prompt editing
• up/down arrows to scroll through history

Waiting on v2.0.0 to release