rgardner / bsh Goto Github PK

Functions can return an enum variant, NULL, or -1, causing the caller to check errno. We can then define our own custom errno values for some issues.

• parser
• stdin/stdout redirection
• command in background
• commands automatically added to history
• repeat commands from history
• jobs
• cd
• history
• exit
• kill
• piping
• fg and bg
• alias
• dirs, pushd, popd
• which

Set up doxygen to automatically create documentation from the code comments. Add rules to the doxygen config file:

WARNINGS               = YES
WARN_IF_UNDOCUMENTED   = YES
WARN_IF_DOC_ERROR      = YES

TODO

• add tests for strlcpy
• add tests for strlcat
• implement strlcpy in bsd.c
• implement strlcat in bsd.c
• replace uses of strncpy, strncat with these functions

Reference:
https://www.sudo.ws/todd/papers/strlcpy.html

Steps To Reproduce

Run bsh:

$ nonexistentprogram
$ nonexistentprogram
$ nonexistentprogram
$ ^D
$ ^D
$ ^D
$ ^D

It seems to be a problem with execvp and creating extra shells when a program cannot be found. The expected behavior is printing an error to the screen.

Bugs

positive indices

$ echo test
$ !1
Segmentation fault: 11

negative indices

$ echo test
$ !-1
tes
$ # should be test
$ echo test2
$ !-1
test
$ # should be test2
$ !-5
Segmentation fault: 11

Use the C/C++ guide on this page as a reference: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style

Use mozilla style, but ensure:

AlignTrailingComments: true
ColumnLimit: 80
PointerBindsToType: true
Language: C or CPP
UseTab: never

If possible, only use these if they differ from the mozilla style.