rfdy / trader Goto Github PK

Hi @rfdy,

you have to change in the release_0_0_1.php file, the permissions for bots to only “see the traders feedbacks”, this line:

            array('permission.permission_set', array('BOTS', array(RatingsManager::U_TRADER_VIEW, RatingsManager::U_TRADER_POST), 'group')),```

Hi,

when i click in my personnal menu box, and when i click on "Trader Feedback", the page is redirected to:

/trader/view-feedback/?u=2

And the message is:

Information

The forum you selected does not exist.

What's wrong ?

Hi,

maybe since your lasts commits on Apr 20, 2015, on /trader/view-feedback/?u=3 page (Trader Feedback for USERNAME), i don't see the informations about feedbacks on next tabs:

• From Buyers
• From Sellers
• From Trades

For others tabs it's OK:

• All Feedback Received
• Left for Others

Hi,

in /ext/rfd/trader/styles/prosilver/template/includes/view_trader_feedback_sidebar.html

There are two language keys which are not used because this code is disable:

                        {# <tr>
                            <td>{MEMBERS_WHO_LEFT_POSITIVE}{L_COLON</td>
                            <td>{{ trader_stats.user_trader_positive }}</td>
                        </tr>
                        <tr>
                            <td>{MEMBERS_WHO_LEFT_NEGATIVE}{L_COLON}</td>
                            <td>{{ trader_stats.user_trader_negative }}</td>
                        </tr> #}

Why ?

Hi,

about this request: https://www.phpbb.com/community/viewtopic.php?p=14042511#p14042511

It's could be better to change the text of three languages keys and add one more language key.

PR proposed here: #19

Hi @rfdy,

i found an old option which was inactivated, why ?

Otherwise there is an error for the old users which use your extension because your migration file does not take in consideration your different updates of the code:

General Error
Cannot find module ./../includes/acp/\rfd\trader\acp\main_module.php

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/includes/functions_module.php
LINE: 571
CALL: trigger_error()

FILE: [ROOT]/adm/index.php
LINE: 81
CALL: p_master->load_active()

Change code was made here: fb1f2ca#diff-e789d4f1cff3962226c0b837a8c7e6f1.

Announcement of this change: https://www.phpbb.com/community/viewtopic.php?p=13921026#p13921026.

• In: Event/TraderListener.php
  In line 344: => FIXED here: 58871b7 and here: 764c88b

            $data['error'][] = "Please select whether your intention is to Buy, Sell or Trade.";

I can't replace this text:

"Please select whether your intention is to Buy, Sell or Trade."

with the language key:

REQUIERED_INTENTION_TO

• In: mcp/mcp_trader_info.php

In line 15

                                    'title' => 'Open Trader reports',

In line 20

                                    'title' => 'Closed Trader reports',

In line 25

                                    'title' =>  'Trader Report details',

I can't replace those texts:
In line 15

Open Trader reports

with the language key:

REPORT_OPEN_TITLE

In line 20

Closed Trader reports

with the language key:

REPORT_CLOSED_TITLE

In line 25

Trader Report details

with the language key:

REPORT_DETAILS_TITLE

Hi,

as you can see all my tests turn principally around the multi-language uses.

I'm French and considering that my test board uses those next settings:

• In ACP => GENERAL => Board settings
  • Date format: D j M Y - H:i
  • Guest timezone: Europe/Paris

I have some issues with displaying of the dates.

1/ First issues on the next pages:

• http://www.domain.tld/trader/view-feedback/?u=3
• http://www.domain.tld/trader/view-feedback/?u=3&tab=all
• http://www.domain.tld/trader/view-feedback/?u=3&tab=buy
• http://www.domain.tld/trader/view-feedback/?u=3&tab=sell
• http://www.domain.tld/trader/view-feedback/?u=3&tab=trade
• http://www.domain.tld/trader/view-feedback/?u=3&tab=left

The displaying is like that: Apr 15, 2015 instead of 15 Avr, 2015
And when you hover the mouse: Apr 15, 2015 - 4:51pm CEST instead of 15 Avr, 2015 - 16:51 UTC+02:00
The date format and timezone are not correct in others languages than ENGLISH because the displaying is in ENGLISH and in CEST date format. It doesn't take in consideration:

• the default board language setting or user language setting (according to if it's a guest or if it's a user registred)
• the default board date format setting or user date format setting (according to if it's a guest or if it's a user registred)
• the default board timezone setting or user timezone setting (according to if it's a guest or if it's a user registred)

2/ Second issue on the next page:

• http://www.domain.tld/trader/edit-feedback/?feedback_id=1&u=3

The displaying is like that: WED 15 APR 2015 - 16:51 instead of Mer 15 Avr 2015 - 16:51
The date format and timezone are correct in all languages but it's displaying in ENGLISH language. It doesn't take in consideration:

• the default board language settings or user language settings (according to if it's a guest or if it's a user registred):

3/Thrid issue on the next pages:

• http://www.domain.tld/mcp.php?i=-rfd-trader-mcp-mcp_trader_module&mode=closed_trader_reports
• http://www.domain.tld/mcp.php?i=\rfd\trader\mcp\mcp_trader_module&mode=trader_report_details&report_id=2

The displaying is like that: Sun Jun 14, 2015 4:32 am instead of Dim 15 Jui 2015 4:32
The timezone is correct in all languages but it's displaying in ENGLISH language and in CEST date format. It doesn't take in consideration:

• the default board language setting or user language setting (according to if it's a guest or if it's a user registred)
• the default board date format setting or user date format setting (according to if it's a guest or if it's a user registred)

hello,
Any update is coming?

Replacement string is missing the app.php part.

/app.php/trader/view-feedback/?u=

Pagination has no way of switching pages.

If using a responsive theme (stock prosilver is responsive), the feedback profile page is squashed into one side.

Hi,

when you activate this extension, in ACP => Permissions => Group permissions => Global moderators
The two next permissions are set on "Yes" even if it's set "no role assigned...":

Can leave trader feedback
Can view trader feedback

If i change the permissions on "NO" for them and i save, those two permissions will be back set on "Yes".

Hi @rfdy,

it’s mentionned some tables “trader_replies” and “trader_topics” in differents files:

• ``release_0_0_1.php`, this code:

                $this->table_prefix . 'trader_replies',
                $this->table_prefix . 'trader_topics',

• parameters.yml, this code:

    tables.trader_replies: %core.table_prefix%trader_replies

• services.yml, this code:

            - { feedback: %tables.trader_feedback%, comments: %tables.trader_comments%, replies: %tables.trader_replies%, reports: %tables.trader_reports% }

But this tables are not created, maybe you have to delete all references about those tables.

Hi,

from this post: https://www.phpbb.com/community/viewtopic.php?p=14041656#p14041656

"leschek wrote:
3./ In miniprofile (in topic) when I hover over "Trader Score" link it shows counts of positive/neutral/negative feedback. Neutral feedback is 0 even if user has a few neutral feedbacks."

I agree with leschek user, it's not fixed.

Hi @rfdy,

could you take a look about this: https://www.phpbb.com/community/viewtopic.php?p=14263401#p14263401.

A notification when you recieve feedback would be ideal, any plans for this?